[MPQEditor] Create or edit mixed precision quantization json file. #1505

stamalakhov · 2023-02-16T07:51:12Z

This commit allows to create or edit mixed precision quantization json file.
To use the tool the following actions are suggested:

right-click in explorer any circle model
context menu should contain "Create MPQ json" - click it
provide name for new .json
after creation of new json we may edit it

Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com

stamalakhov · 2023-02-16T08:34:30Z

More info:

media/CircleGraph/index.js

seanshpark · 2023-02-16T23:22:34Z

media/CircleGraph/index.js

@@ -52,6 +52,7 @@ const viewMode = {
  viewer: 0, // default circle viewer
  selector: 1, // circle partition editor node selector
  visq: 2, // quantization error viewer
+  visqselr: 3, //quantization error viewer whicj is able to select nodes


why is this mode added?
what is visqselr? this word is hard to read.

why is this mode added?

new mode is intended to provide .visq colormap, as well as selector capabilities to provide a user handy selection of nodes.

what is visqselr? this word is hard to read.

Yes. The name is hard to read, i'll gladly change it with any other more fortunate name.

seanshpark · 2023-02-16T23:23:13Z

media/CircleGraph/index.js

+          } else if (message.mode === "visq") {
+            this._mode = viewMode.visq;
+          } else if (message.mode === "visqselr") {
+            this._mode = viewMode.visqselr;


only put this line as there is no other change

only put this line as there is no other change

Sorry. I don't quite get it. Current implementation assumes that we can change html _mode to another mode, so these lines are intended to provide full enumeration of viewMode, but for now only visqselr is enough.

but for now only visqselr is enough.

this is the point. check only for visqselr. setting to other modes are never called.

Ahhh. Thank you. Ok.

src/MPQEditor/MPQCircleSelector.ts

jinevening · 2023-02-17T01:10:12Z

Q) How visq info is created? Is it assumed to be generated before? If so, it would be better to give instruction on how to make visq info (e.g., making a small question mark icon near the "Load visq info" button). BTW, is it possible to create visq info in ONE-vscode?

(optional) I think it is better to show the model graph by default when the tab is first created. I guess most users will want to select layers in the graph with visq info.

stamalakhov · 2023-02-17T05:34:59Z

Q) How visq info is created? Is it assumed to be generated before?

Yes, for this draft it was generated before.

If so, it would be better to give instruction on how to make visq info (e.g., making a small question mark icon near the "Load visq info" button)

ok.

BTW, is it possible to create visq info in ONE-vscode?

I'll investigate it.

(optional) I think it is better to show the model graph by default when the tab is first created. I guess most users will want to select layers in the graph with visq info.

Ok.

I'll be back with reworked draft.

stamalakhov · 2023-02-17T11:21:05Z

Currently the workflow looks like this:

stamalakhov · 2023-02-20T12:22:49Z

BTW, is it possible to create visq info in ONE-vscode?

I've tried to introduce visq data computation into MPQEditor and it occured to be heavy:
input for float model
input for quantized model
input for h5 data
ouput for MPEIR mode
ouput for MSE mode
...
to be continued

IMHO for visq component we may try to create additional command in ONE-vscode.
@jinevening
May be we could do another item in context menu for circle file like "Create VISQ data" ?

stamalakhov · 2023-02-20T12:58:17Z

@jinevening @seanshpark
Please see docs/MPQEditor.md for readme.
For now model-graph-view is opened by default.
And help btn is also introduced into visq_path input.

seanshpark · 2023-02-20T21:41:17Z

Thanks for video attach at #1505 (comment) :)

Q1) what happens if wrong json (not visq info content) is selected in visq info ?
Q2) what happens if wrong json (visq info content but for different model) is selected in visq info ?
Q3) there seems to be no way to clear loaded visq info. is there any particular reason for this?

model.json filename doesn't seem to be appropriate. we can't distinguish by just .json. how about use model.blabla.json ? @jinevening , do you have any good word for blabla ?

package.json

src/MPQEditor/MPQCircleSelector.ts

dayo09 · 2023-02-20T23:48:37Z

src/MPQEditor/MPQCircleSelector.ts

+  }
+
+  public onLoadVisqInfo(visqPath: string) {
+    const fileData = fs.readFileSync(visqPath, { encoding: "utf8", flag: "r" });


AFAIK, it's rather safer to use vscode.workspace.fs.readFile instead of fs.readFileSync. Related issue: #746

Ok. Thank you. I didn't know that.

dayo09 · 2023-02-20T23:50:02Z

src/MPQEditor/MPQCircleSelector.ts

+        if (this._panel.visible) {
+          // NOTE if we call this.update(), it'll reload the model which may take time.
+          // TODO call conditional this.update() when necessary.
+          // this.update();


Q. Is it fine with this.update() being commented out?

Ah... Sorry. I'll remove that.

dayo09 · 2023-02-20T23:55:18Z

src/MPQEditor/MPQCircleSelector.ts

+    // let parsedPath = path.parse(args.docPath);
+    // let fileBase = path.join(parsedPath.dir, parsedPath.name);


Could it be removed, if it's not used?

Ahhh.. Sorry. These lines will be removed.

src/MPQEditor/MPQCircleSelector.ts

seanshpark · 2023-02-21T00:10:13Z

docs/MPQEditor.md

+5) all layers from 'layers' section in json are shown in grid-table, so that their options for quantization can be edited using their respective dropdowns
+6) to make 'model-graph-view' more informative the user may use 'visq' information, it shows which layers are more sensitive to quantization than others
+
+<img src="./images/MPQ_UI.png"/>


please refine this image. do not use red color for text. use smaller size for explanation.

Add "Default Parameters" in GUI not in this image.

Ahhh... Sorry. I'll fix it.

stamalakhov self-assigned this Feb 16, 2023

stamalakhov force-pushed the manual_MPQ_BR branch 2 times, most recently from 3702a75 to ea65d9e Compare February 16, 2023 08:02

stamalakhov requested review from dayo09 and seanshpark February 16, 2023 08:04

stamalakhov requested a review from jinevening February 16, 2023 08:34

seanshpark reviewed Feb 16, 2023

View reviewed changes

media/CircleGraph/index.js Outdated Show resolved Hide resolved

seanshpark reviewed Feb 16, 2023

View reviewed changes

media/CircleGraph/index.js Outdated Show resolved Hide resolved

seanshpark reviewed Feb 16, 2023

View reviewed changes

src/MPQEditor/MPQCircleSelector.ts Outdated Show resolved Hide resolved

stamalakhov marked this pull request as draft February 17, 2023 05:19

stamalakhov force-pushed the manual_MPQ_BR branch 2 times, most recently from b87a618 to a9ebb2d Compare February 20, 2023 09:56

stamalakhov force-pushed the manual_MPQ_BR branch from a9ebb2d to 36471ce Compare February 20, 2023 12:51

stamalakhov requested a review from seanshpark February 20, 2023 12:58

dayo09 reviewed Feb 20, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

dayo09 reviewed Feb 20, 2023

View reviewed changes

src/MPQEditor/MPQCircleSelector.ts Outdated Show resolved Hide resolved

dayo09 reviewed Feb 20, 2023

View reviewed changes

src/MPQEditor/MPQCircleSelector.ts Outdated Show resolved Hide resolved

seanshpark reviewed Feb 21, 2023

View reviewed changes

dayo09 mentioned this pull request May 2, 2023

[MPQEditor] Make layout more user-friendly #1541

Open

This was referenced May 2, 2023

[MPQEditor] Update MPQCircleSelector for visq processing #1549

Merged

[MPQEditor] Implement UI messages #1550

Merged

This was referenced May 11, 2023

[MPQEditor] Implement handleLoadVisqFile #1555

Merged

[MPQEditor] Implement 'cancelScrollToSelected' #1556

Merged

stamalakhov mentioned this pull request May 22, 2023

[MPQEditor] Handle invalid VISQ data #1561

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MPQEditor] Create or edit mixed precision quantization json file. #1505

[MPQEditor] Create or edit mixed precision quantization json file. #1505

stamalakhov commented Feb 16, 2023 •

edited

Loading

stamalakhov commented Feb 16, 2023

seanshpark Feb 16, 2023

seanshpark Feb 16, 2023

stamalakhov Feb 17, 2023

seanshpark Feb 16, 2023

stamalakhov Feb 17, 2023

seanshpark Feb 17, 2023

stamalakhov Feb 17, 2023

jinevening commented Feb 17, 2023

stamalakhov commented Feb 17, 2023

stamalakhov commented Feb 17, 2023 •

edited

Loading

stamalakhov commented Feb 20, 2023

stamalakhov commented Feb 20, 2023

seanshpark commented Feb 20, 2023 •

edited

Loading

dayo09 Feb 20, 2023

stamalakhov Feb 21, 2023

dayo09 Feb 20, 2023

stamalakhov Feb 21, 2023

dayo09 Feb 20, 2023

stamalakhov Feb 21, 2023

seanshpark Feb 21, 2023

seanshpark Feb 21, 2023

stamalakhov Feb 21, 2023

		// let parsedPath = path.parse(args.docPath);
		// let fileBase = path.join(parsedPath.dir, parsedPath.name);

[MPQEditor] Create or edit mixed precision quantization json file. #1505

Are you sure you want to change the base?

[MPQEditor] Create or edit mixed precision quantization json file. #1505

Conversation

stamalakhov commented Feb 16, 2023 • edited Loading

stamalakhov commented Feb 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jinevening commented Feb 17, 2023

stamalakhov commented Feb 17, 2023

stamalakhov commented Feb 17, 2023 • edited Loading

stamalakhov commented Feb 20, 2023

stamalakhov commented Feb 20, 2023

seanshpark commented Feb 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stamalakhov commented Feb 16, 2023 •

edited

Loading

stamalakhov commented Feb 17, 2023 •

edited

Loading

seanshpark commented Feb 20, 2023 •

edited

Loading