Skip to content

Commit

Permalink
applied code review
Browse files Browse the repository at this point in the history
  • Loading branch information
zetwhite committed May 14, 2024
1 parent f75695a commit 611daaa
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
10 changes: 5 additions & 5 deletions tools/circle_plus_gen/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@

def get_cmd_args():
parser = argparse.ArgumentParser(
prog='circle plus generator',
description='help handle circle file with training hyperparameters')
prog='circle_plus_gen',
description='circle_plus_gen help handle circle file with training hyperparameters'
)

parser.add_argument(
'input_circle_file', metavar="input.circle", type=str, help='input circle file')
parser.add_argument('input', help='input circle file')

args = parser.parse_args()
return args
Expand All @@ -35,6 +35,6 @@ def print_training_hparameters(in_circle_file) -> typing.NoReturn:
if __name__ == "__main__":
args = get_cmd_args()

print_training_hparameters(args.input_circle_file)
print_training_hparameters(args.input)

# TODO: add a function that injects training parameter into circle file
7 changes: 2 additions & 5 deletions tools/circle_plus_gen/schema/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# In this directory, *_generated.py is auto generated by flatc.
#
# * flatc version 23.5.26 is used
# * /ONE/nnpackage/schema/circle_schema.fbs is used
# * /ONE/runtime/libs/circle-schema/include/circle_traininfo.fbs is used
#
# ./flatc --python --gen-onefile --gen-object-api circle_schema.fbs
# ./flatc --python --gen-onefile --one-object-api cricle_traininfo.fbs
# ./flatc --python --gen-onefile --gen-object-api ../../../nnpackage/schema/circle_schema.fbs
# ./flatc --python --gen-onefile --one-object-api ../../../runtime/libs/circle-schema/include/circle_traininfo.fbs

0 comments on commit 611daaa

Please sign in to comment.