[onert] Introduce CodegenManager class #12553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces CodegenManager class. This class runs codegen() function to load target backend library and call the codegen function. ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com> Co-authored-by: Sanggyu Lee <sg5.lee@samsung.com>
6 tasks
YongseopKim
reviewed
Jan 30, 2024
| namespace odc | ||
| { | ||
|
|
||
| bool CodegenManager::codegen(const char *target, CodegenPreference pref) |
There was a problem hiding this comment.
I'm not sure what target is but code that is checking the target is necessary, I think.
There was a problem hiding this comment.
target is the term in compiler. source and target. You may think it as the binary of codegen. I agree to add check.
There was a problem hiding this comment.
You can find the detail explanation of target string in header file.
* @param target Target backend name
* This target string will be used to find a backend library.
* The name of target backend library should follow the following rules:
* 'lib' + {backend extension} + '-gen' + {lib extension}
* And the target string should be a name except 'lib' and {lib extension}.
* For example, if the backend extension is 'aaa', the backend library name
* should be 'libaaa-gen.so', and the target string should be 'aaa-gen'.
This Codegen manager dynamically loads the target library. To find a shared library, a search policy must be defined. In this case, the library is searched for using this target string.
ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
|
PTAL all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces CodegenManager class.
This class runs codegen() function to load target backend library and call the codegen function.
ONE-DCO-1.0-Signed-off-by: Jiyoung Yun jy910.yun@samsung.com
Co-authored-by: Sanggyu Lee sg5.lee@samsung.com
Related issue : #12505
Draft PR: #12504