This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
Refactoring CircularShell Renderer #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rookiejava
changed the title
rookiejava
reviewed
May 13, 2020
|
|
||
| protected override NavigationDrawer CreateNavigationDrawer(EvasObject parent) | ||
| { | ||
| return _drawer = base.CreateNavigationDrawer(EvasObject parent); |
There was a problem hiding this comment.
return _drawer = base.CreateNavigationDrawer(parent);
| RegisterPropertyHandler(CircularShell.FlyoutForegroundColorProperty, UpdateFlyoutForegroundColor); | ||
| } | ||
|
|
||
| protected override NavigationDrawer CreateNavigationDrawer(EvasObject parent) |
There was a problem hiding this comment.
Should use alias as below to avoid build error.
using NavigationDrawer = Xamarin.Forms.Platform.Tizen.Watch.NavigationDrawer;
using NavigationView = Xamarin.Forms.Platform.Tizen.Watch.NavigationView;
|
This change is already merged into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refactoring CircularShellRenderer to use XF.ShellRenderer
Bugs Fixed
None
API Changes
None
Behavioral Changes
None