This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
Update CircleListViewRenderer #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyunMin
approved these changes
May 13, 2020
rookiejava
reviewed
May 13, 2020
src/Tizen.Wearable.CircularUI.Forms.Renderer/CircleListViewRenderer.cs
Outdated
Show resolved
Hide resolved
| _selectedItemChanging++; | ||
| Element.NotifyRowTapped(index); | ||
| _selectedItemChanging--; | ||
| (Control as WatchListView).CircleGenList.VerticalScrollBarColor = Element.BarColor.ToNative(); |
There was a problem hiding this comment.
(Control as WatchListView).?
There was a problem hiding this comment.
can't because assign statement
rookiejava
approved these changes
May 13, 2020
|
Should remove |
rookiejava
pushed a commit
to rookiejava/Tizen.CircularUI
that referenced
this pull request
May 17, 2020
* Update CircleListViewRenderer * Apply Review comment
rookiejava
pushed a commit
to rookiejava/Tizen.CircularUI
that referenced
this pull request
May 19, 2020
* Update CircleListViewRenderer * Apply Review comment
rookiejava
added a commit
that referenced
this pull request
May 19, 2020
* Refactoring CircularShell Renderer * Update bezel interaction behavior (#299) * Refactoring CircularShell Renderer * Update bezel interaction behavior * Update OnMoreOptionOpened/Closed * Update CircleScrollViewRenderer (#300) * Update CircleScrollViewRenderer * Obsolete BarColor property in CircleScrollView * Update the CircleScrollViewRenderer (#301) * Update CircleStepperRenderer and CircleDateTimeSelectorRenderer (#296) * Update ActiveBezelInteractionElement on Activate bezel interaction (#302) * Update CircleListViewRenderer (#303) * Update CircleListViewRenderer * Apply Review comment * Update Bezel Intercation behavior on closing dialog (#304) * Remove unused ListViewCache * Update Renderer to use disable rotary event on IBezelInteractionRoutor (#305) * Fix ExportRenderer (#306) * Fix CheckRendererer to avoid registerPropertyhandler issue * Fix build error on WearableGallery Co-authored-by: Seungkeun Lee <sngn.lee@samsung.com> Co-authored-by: shmin <shyun.min@samsung.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update CircleListViewRenderer to reuse X.F.ListViewRenderer
Bugs Fixed
None
API Changes
Removed :
Tizen.Wearable.CircularUI.Forms.Renderer.CircleListView class
Behavioral Changes
None