This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
Enhance the Page renderer #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myroot
approved these changes
Jun 12, 2020
rookiejava
added a commit
to rookiejava/Tizen.CircularUI
that referenced
this pull request
Jun 18, 2020
This reverts commit 1c20798.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a fix to support adding/deleting page toolbar items at runtime.
I've temporarily moved the Xamarin.Forms.PageRenderer implementation to support this feature in CircularUI even before a new package of Xamarin.Forms is published. When a new Xamarin.Forms package with a patch enabling it is published, it will be changed to inherit PageRenderer again.
Bugs Fixed
None
API Changes
None