Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should deinitialize database after removing relations (db_cleanup). #1368

Merged
merged 1 commit into from Mar 23, 2018

Conversation

ahmet-celik
Copy link
Contributor

Original code tries to remove the relation after deinitializing database. I observed kernel panic due to illegal memory access occasionally during the execution of arastorage_itc tests on ARTIK053 board. After this fix, I did not observe the kernel panic.

@seinfra
Copy link

seinfra commented Mar 22, 2018

Code Rule Check OK.

@sunghan-chang
Copy link
Contributor

sunghan-chang commented Mar 23, 2018

@ahmet-celik Thank you for contribution. Every developer checks commit, not pull request so that we think commit title and description are much important. Could you copy your pull request description into commit description like below?

testcase: Should deinitialize database after removing relations (db_cleanup).

Original code tries to remove the relation after deinitializing database.
I observed kernel panic due to illegal memory access occasionally
during the execution of arastorage_itc tests on ARTIK053 board.
After this fix, I did not observe the kernel panic.

…leanup).

Original code tries to remove the relation after deinitializing database.
I observed kernel panic due to illegal memory access occasionally
during the execution of arastorage_itc tests on ARTIK053 board.
After this fix, I did not observe the kernel panic.
@ahmet-celik
Copy link
Contributor Author

I updated commit message.

@seinfra
Copy link

seinfra commented Mar 23, 2018

Code Rule Check OK.

@sunghan-chang sunghan-chang merged commit a115224 into Samsung:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants