build/tools/amebasmart: Modify Flash Protection Status Register #6111
Conversation
ZhenBei-Sin
force-pushed
the
FlashProtection
branch
from
05c4811
to
7e728c9
Compare
|
@ZhenBei-Sin Why is this happened? There was no requirement change on this ever. |
|
@ZhenBei-Sin Please update the |
Let's do this with new PR, not in this PR. |
ZhenBei-Sin
force-pushed
the
FlashProtection
branch
from
7e728c9
to
8d7717a
Compare
| /* Flash Status Bit Protect Lower 512KB */ | ||
| #ifdef CONFIG_AMEBAD_TRUSTZONE | ||
| #define FLASH_STATUS_BITS 0x2c | ||
| #endif | ||
| #ifdef CONFIG_AMEBASMART_TRUSTZONE | ||
| #define FLASH_STATUS_BITS 0x28 | ||
| #endif |
There was a problem hiding this comment.
I don't know this is proper. I don't have any requirement change on this. But anyway, when we want to change the region, we should modify several files. And it could be mismatched.
How about making this as a config?
And here are amebad and amebasmart only. How about amebalite? Because we support it, I ask you this.
There was a problem hiding this comment.
Different IC packaging uses different Flash, it has different Status bits values.
We will base it on previous AmebaLite packaging, thus it's the same as AmebaD.
We will create another PR to change this setting to a config, is that okay?
There was a problem hiding this comment.
Different IC packaging uses different Flash, it has different Status bits values.
We will base it on previous AmebaLite packaging, thus it's the same as AmebaD.
Because of that, I suggest making a config to set for different boards configuration.
We will create another PR to change this setting to a config, is that okay?
Sure
Changes Note: Modify the Flash Protection Status Register from 0x2C to 0x28 To protect 512KB of flash
ZhenBei-Sin
force-pushed
the
FlashProtection
branch
from
8d7717a
to
9944bdb
Compare
Yes~ please proceed to merge. Thank you ~ |
Changes Note:
Modify the Flash Protection Status Register from 0x2C to 0x28 To protect 512KB of flash