Fix inline caching of object set #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
clover2123
force-pushed
the
pr
branch
3 times, most recently
from
495b189
to
8fbc1e8
Compare
clover2123
commented
Mar 11, 2024
Comment on lines
-318
to
+313
| if (nextSize > ESCARGOT_OBJECT_STRUCTURE_ACCESS_CACHE_BUILD_MIN_SIZE) { | ||
| newObjectStructure = new ObjectStructureWithMap(nameIsIndexString, hasSymbol, hasEnumerableProperty, m_properties, newItem); | ||
| } else if (nextSize > ESCARGOT_OBJECT_STRUCTURE_TRANSITION_MODE_MAX_SIZE || nameIsIndexString) { | ||
| // ObjectStructureWithTransition cannot directly convert to ObjectStructureWithMap by just adding one property | ||
| ASSERT(nextSize < ESCARGOT_OBJECT_STRUCTURE_ACCESS_CACHE_BUILD_MIN_SIZE); | ||
| if (nextSize > ESCARGOT_OBJECT_STRUCTURE_TRANSITION_MODE_MAX_SIZE || nameIsIndexString) { |
There was a problem hiding this comment.
ObjectStructureWithTransition cannot directly convert to ObjectStructureWithMap by just adding one property,
So I removed it.
Comment on lines
2867
to
2873
| // finally, insert a valid new cache item at the end | ||
| // because an exception could occur ahead which makes insertion of cache item invalid | ||
| if (inlineCache->m_cache.size() > SetObjectInlineCacheData::MaxCacheCount) { | ||
| for (size_t i = inlineCache->m_cache.size() - 1; i > 0; i--) { | ||
| inlineCache->m_cache[i] = inlineCache->m_cache[i - 1]; | ||
| } | ||
| } else { | ||
| inlineCache->m_cache.insert(0, SetObjectInlineCacheData()); | ||
| block->m_inlineCacheDataSize += sizeof(SetObjectInlineCacheData); | ||
| currentCodeSizeTotal += sizeof(SetObjectInlineCacheData); | ||
| } |
There was a problem hiding this comment.
Adding a new cache item at the end of setObjectPreComputedCaseOperationSlowCase operation because exceptions could arise in the middle of its execution, which may lead to insertion of an imperfact cache item.
* fix inline caching to insert a new cache item after validation * refactor set inline caching method Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
ksh8281
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.