Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TypedArrays as regular objects instead of array objects in builtinJSONStringify #38

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Conversation

pmarkee
Copy link
Contributor

@pmarkee pmarkee commented Jan 3, 2019

…ltinJSONStringify

Fixes #31

Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu

…ltinJSONStringify

Fixes #31

Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu
@akosthekiss akosthekiss changed the title Handle TypedArrays as regular objects instead of array objects in bui… Handle TypedArrays as regular objects instead of array objects in builtinJSONStringify Jan 3, 2019
Copy link
Contributor

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit 12525b5 into Samsung:master Jan 4, 2019
@pmarkee pmarkee deleted the fix-isarrayobject branch March 19, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants