Skip to content

Commit

Permalink
[AutoOnboarding] Fix result dialog issue
Browse files Browse the repository at this point in the history
[Problem]
1. After a repeat test ends, 'Save and quit' button is not working
2. The below logs keep printing
Traceback (most recent call last):
File "/home/matter/spdkimo/ioter/src/common/common_window.py", line 472, in checkPosition
self.timer.stop()
AttributeError: 'NoneType' object has no attribute 'stop'

[Measure]
1. Remove button
2. Update the timer check condition
  • Loading branch information
spdkimo committed Jun 29, 2023
1 parent e335607 commit 5c6b667
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/auto_onboarding/auto_onboardingmain.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ def __init__(self):
uic.loadUi(Utils.get_view_path('reportDialog.ui'), self)
self.reset()
self.btn_quit.clicked.connect(self.dlg_quit)
self.btn_save_and_quit.setVisible(False)
self.setWindowTitle("Onboarding Report")

## Quit report dialog ##
Expand Down
2 changes: 1 addition & 1 deletion src/common/common_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ def moveEvent(self, event):

## Check window postion ##
def checkPosition(self):
if self.timer is not None and not self.timer.isActive():
if self.timer is None or not self.timer.isActive():
return
if self.frameGeometry() == self.cur_pos:
# Window stopped to move
Expand Down

0 comments on commit 5c6b667

Please sign in to comment.