spinbox function add in window covering #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junyong-sim
reviewed
Jun 28, 2023
gdinolee
force-pushed
the
feature/windows_spinbox
branch
from
655020d
to
b5874a5
Compare
gdinolee
force-pushed
the
feature/windows_spinbox
branch
from
f58541a
to
c0eb417
Compare
junyong-sim
approved these changes
Jun 29, 2023
| self.spinBoxWindow.valueChanged.connect(self.spin_value_changed) | ||
| self.spinBoxWindow.setSingleStep(1) | ||
|
|
||
|
|
| def init_spinbox(self): | ||
| self.spinBoxWindow.installEventFilter(self) | ||
| self.spinBoxWindow.valueChanged.connect(self.spin_value_changed) | ||
| self.spinBoxWindow.setSingleStep(1) |
There was a problem hiding this comment.
Since the init_spinbox function has been created, the following spinbox contents of init_slider function must be moved.
self.spinBoxWindow.setRange(
WINDOWCOVERING_MIN_VAL, WINDOWCOVERING_MAX_VAL)
self.spinBoxWindow.setSingleStep(
self.common_window.get_slider_single_step(WINDOWCOVERING_MIN_VAL, WINDOWCOVERING_MAX_VAL))
self.spinBoxWindow.setValue(WC_INIT_LEVEL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified to operate when the arrow button of the spinbox is pressed in window covering
Spinbox code clean up