Check for undefined or null functions. Fixes #96 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arranf
commented
Jul 8, 2016
arranf
commented
- Add checks for undefined or null functions and pass in undefined f[SPECIAL_PROP_IID] and f[SPECIAL_PROP_SID] to avoid TypErrors from reading the property of an undefined or null
- If the function is undefined or null return the result of function as undefined.
* Add checks for undefined or null functions and pass in undefined f[SPECIAL_PROP_IID] and f[SPECIAL_PROP_SID] to avoid TypErrors from reading the property of an undefined or null * If the function is undefined or null return the result of function as undefined.
|
@ksen007 I just wanted to follow up on this PR. Is there anything here that needs changing? |
|
Sorry about not getting back to this early about an error that I noticed. There is a mistake at line 207. Esben posted another pull request which seems to have no bug. |
|
Going to close this one out. Thanks for the contribution, and sorry for the slow response. We'll do better in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.