Skip to content

Commit

Permalink
Worked fine just not on office network :-@ Tidying up
Browse files Browse the repository at this point in the history
  • Loading branch information
@poshaughnessy
poshaughnessy committed Nov 14, 2017
1 parent 5032283 commit 46435f4
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 29 deletions.
30 changes: 15 additions & 15 deletions index.html
View file
Expand Up @@ -27,32 +27,32 @@ <h2>Audience</h2>
<div>
<h3>126.8K</h3>
<p>Dev Hub unique visitors</p>
<p class="change"><span class="arrow up">↑</span> 684.6% (0 days)</p>
<p class="change"><span class="arrow up">↑</span> 684.6% (34 days)</p>
</div>
<div>
<h3>2.0K</h3>
<p>Medium followers</p>
<p class="change"><span class="arrow up">↑</span> 11.1% (0 days)</p>
<p class="change"><span class="arrow up">↑</span> 11.1% (34 days)</p>
</div>
<div>
<h3>1.2K</h3>
<p>Twitter followers</p>
<p class="change"><span class="arrow up">↑</span> 8.9% (0 days)</p>
<p class="change"><span class="arrow up">↑</span> 8.9% (34 days)</p>
</div>
<div>
<h3>273</h3>
<p>Facebook followers</p>
<p class="change"><span class="arrow up">↑</span> 30 (0 days)</p>
<p class="change"><span class="arrow up">↑</span> 30 (34 days)</p>
</div>
<div>
<h3>6.0K</h3>
<p>Facebook reach</p>
<p class="change"><span class="arrow down">↓</span> -65.0% (0 days)</p>
<p class="change"><span class="arrow down">↓</span> -65.0% (34 days)</p>
</div>
<div>
<h3>46</h3>
<p>Instagram followers</p>
<p class="change"><span class="arrow up">↑</span> 7 (0 days)</p>
<p class="change"><span class="arrow up">↑</span> 7 (34 days)</p>
</div>
</div>
<p class="summary">Total social media followers: <strong>3.5K</strong></p>
Expand Down Expand Up @@ -88,28 +88,28 @@ <h3>45.7K</h3>
<h2>Open Source (Github)</h2>
<div class="numbers">
<div>
<h3></h3>
<h3>33</h3>
<p>Repositories</p>
</div>
<div>
<h3></h3>
<h3>183</h3>
<p>Stars</p>
</div>
<div>
<h3></h3>
<h3>40</h3>
<p>Forks</p>
</div>
</div>
<h2>Support (Github &amp; Stack Overflow)</h2>
<div class="numbers">
<div>
<h3></h3>
<h3>16</h3>
<p>Open Issues</p>
</div>
<div>
<h3>5</h3>
<p>Time To Close Issues (months, avg)</p>
<p class="change"><span class="arrow up"></span> up</p>
<p class="change"><span class="arrow "></span> N/A</p>
</div>
</div>
<h2>Blogging (Medium)</h2>
Expand All @@ -125,25 +125,25 @@ <h2>SEO</h2>
<h4>WebVR</h4>
<h3>48</h3>
<p>https://samsunginter.net/docs/webvr</p>
<p class="change"><span class="arrow down">↓</span> N/A (0 days)</p>
<p class="change"><span class="arrow "></span> N/A (34 days)</p>
</div>
<div>
<h4>Web Payments</h4>
<h3>13</h3>
<p>https://samsunginter.net/docs/web-payments</p>
<p class="change"><span class="arrow up">↑</span> 14 (0 days)</p>
<p class="change"><span class="arrow up">↑</span> 14 (34 days)</p>
</div>
<div>
<h4>Progressive Web Apps</h4>
<h3>12</h3>
<p>https://medium.com/samsung-internet-dev/6-myths-of-progressive-web-apps-81e28ca9d2b1</p>
<p class="change"><span class="arrow down">↓</span> <span id="seo-pwas-change"></span> (<span id="seo-pwas-change-label"></span>)</p>
<p class="change"><span class="arrow "></span> <span id="seo-pwas-change"></span> (<span id="seo-pwas-change-label"></span>)</p>
</div>
<div>
<h4>Physical Web</h4>
<h3 id="seo-physicalweb"></h3>
<p id="seo-physicalweb-link">Outside top 250</p>
<p class="change"><span class="arrow down">↓</span> <span id="seo-physicalweb-change"></span> (<span id="seo-physicalweb-change-label"></span>)</p>
<p class="change"><span class="arrow "></span> <span id="seo-physicalweb-change"></span> (<span id="seo-physicalweb-change-label"></span>)</p>
</div>
</div>
<h2>Surveys</h2>
Expand Down
9 changes: 3 additions & 6 deletions src/template.html
View file
Expand Up @@ -76,7 +76,7 @@ <h3>${facebook.engagement.views.formattedCount}</h3>
<div>
<h3>${facebook.engagement.engagements.formattedCount}</h3>
<p>Facebook engagements (28 days)</p>
<p class="change"><span class="arrow ${facebook.engagement.engagements.changeDirection}">${facebook.engagement.engagements.changeArrow}</span> ${facebook.engagement.engagements.changeDirection}</p>
<p class="change"><span class="arrow ${facebook.engagement.engagements.changeDirection}">${facebook.engagement.engagements.changeArrow}</span> ${facebook.engagement.engagements.change}</p>
</div>
<div>
<h3>${medium.engagement.views.formattedCount}</h3>
Expand All @@ -85,7 +85,7 @@ <h3>${medium.engagement.views.formattedCount}</h3>
</div>
</div>
<p class="summary">Total impressions/views: <strong>${totalImpressions}</strong></p>
<h2>Open Source (Github)</h2>
<h2>Open Source &amp; Support (Github)</h2>
<div class="numbers">
<div>
<h3>${github.repositories}</h3>
Expand All @@ -99,17 +99,14 @@ <h3>${github.stars}</h3>
<h3>${github.forks}</h3>
<p>Forks</p>
</div>
</div>
<h2>Support (Github &amp; Stack Overflow)</h2>
<div class="numbers">
<div>
<h3>${github.issues.openIssues}</h3>
<p>Open Issues</p>
</div>
<div>
<h3>${github.issues.closeTimeAvg.count}</h3>
<p>Time To Close Issues (months, avg)</p>
<p class="change"><span class="arrow ${github.issues.closeTimeAvg.changeDirection}"></span> ${github.issues.closeTimeAvg.changeDirection}</p>
<p class="change"><span class="arrow ${github.issues.closeTimeAvg.changeDirection}">${github.issues.closeTimeAvg.changeArrow}</span> ${github.issues.closeTimeAvg.change}</p>
</div>
</div>
<h2>Blogging (Medium)</h2>
Expand Down
17 changes: 11 additions & 6 deletions update.js
View file
Expand Up @@ -28,9 +28,16 @@ function updateStatWithChange(data, comparisonData, pathToStat, lowerIsBetter) {
stat.formattedCount = utils.formatNumberValue(count);
stat.change = utils.formatChangeValue(count, comparisonCount, lowerIsBetter);
stat.changeLabel = comparisonDaysDiff + ' days';
stat.changeArrow = changeDirection === 'up' ? upArrow : downArrow;
stat.changeDirection = changeDirection;
stat.changeArrow = '';

if (changeDirection === 'up') {
stat.changeArrow = upArrow;
} else if (changeDirection === 'down') {
stat.changeArrow = downArrow;
} else {
}

if (stat.link) {
stat.formattedlink = utils.formatDisplayUrl(stat.link);
}
Expand Down Expand Up @@ -84,8 +91,6 @@ function processStats(stats, comparisonStats) {

function updateWithGithubStats(processedStats, githubStats) {

console.log('githubStats 2', githubStats);

var totalStars = 0;
var totalForks = 0;
var supportRepo;
Expand Down Expand Up @@ -114,11 +119,8 @@ function updateWithGithubStats(processedStats, githubStats) {
const templateHtml = fs.readFileSync('src/template.html', 'utf8');
let processedStats = processStats(stats, comparisonStats);

console.log('Why doesnt this work...');

fetch(GITHUB_API_REPOS_URL)
.then(function(response) {
console.log('NEVER GETS HERE! WHY??!!');
return response.json();
})
.then(function(githubStats) {
Expand All @@ -134,4 +136,7 @@ fetch(GITHUB_API_REPOS_URL)
console.log('Updated index.html ✔');
}
});
})
.catch(function(error) {
console.log('Error fetching Github stats', error);
});
6 changes: 4 additions & 2 deletions utils.js
View file
Expand Up @@ -75,14 +75,16 @@ const utils = {
},

/**
* Return 'up' or 'down' string
* Return 'up', 'down' or blank string
*/
getChangeDirection: function(count, comparisonCount, lowerIsBetter) {

if (count - comparisonCount < 0) {
return lowerIsBetter ? 'up' : 'down';
} else {
} else if (comparisonCount - count < 0) {
return lowerIsBetter ? 'down' : 'up';
} else {
return '';
}

}
Expand Down

0 comments on commit 46435f4

Please sign in to comment.