Save Activities #60
Merged
Save Activities #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelWillis
force-pushed
the
save-activities
branch
from
9c03aea
to
64e3111
Compare
This was referenced Nov 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR that will gather and persist activities.
To Do:
Notes
Working on this has exposed a bit of complexity to the
DataCollectionmodule, it's doing a lot of things and those things are a little spread out. I think that module could be split up to follow learnings from Designing Elixir Systems with OTP book.Would be interesting to apply their methodology to this codebase.
I am also starting to notice that a "business logic" split to the Contexts is leading to a bit of complexity possibly? Or I haven't gone extreme enough in that direction, ex: Gear, Athlete module.