Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheels on Pypi #16

Closed
chezou opened this issue Nov 5, 2018 · 11 comments
Closed

Add wheels on Pypi #16

chezou opened this issue Nov 5, 2018 · 11 comments

Comments

@chezou
Copy link
Contributor

chezou commented Nov 5, 2018

Since wheel format is standard for distributing Python packages, it would be nice if we can get wheel from Pypi.

@zackw
Copy link
Collaborator

zackw commented Nov 5, 2018

I agree, we should have both wheels and official source releases on PyPI. @SamuraiT do you have any plans for this or should I look into it?

@SamuraiT
Copy link
Owner

nice to have it. please look into it!

@zackw
Copy link
Collaborator

zackw commented Nov 13, 2018

I've successfully uploaded a source distribution of 0.996.1 to PyPI. Wheels to follow as soon as I figure out how to persuade Travis to build them (might be a couple more days, there's a tool for this but I anticipate some nasty remote debugging).

@chezou
Copy link
Contributor Author

chezou commented Nov 13, 2018

I've succeeded to build manylinux1 wheel on travis-ci. https://github.com/chezou/mecab-python3/tree/release-wheel
Currently working on OSX wheel build.

@chezou chezou mentioned this issue Nov 13, 2018
5 tasks
@miinhtn
Copy link

miinhtn commented Dec 11, 2018

I've succeeded to build manylinux1 wheel on travis-ci. https://github.com/chezou/mecab-python3/tree/release-wheel
Currently working on OSX wheel build.

@chezou do you have any plan to build wheel package on linux (ubuntu 18)

@chezou
Copy link
Contributor Author

chezou commented Dec 11, 2018

@miinhtn I've sent a PR and once it will be merged, you can get a wheel for linux. I'm waiting for review.

@miinhtn
Copy link

miinhtn commented Dec 11, 2018

@chezou actually I visited your github and downloaded the wheel file. It worked (in my simple test) like charm on OSX. 👍 but wonder how it gonna be on linux

@zackw
Copy link
Collaborator

zackw commented Dec 11, 2018

@chezou I don't expect to have time to review your patches properly until next week. Sorry for the delay, day job is in crunch mode right now.

@chezou
Copy link
Contributor Author

chezou commented Dec 11, 2018

Thanks @zackw for taking care of it. I didn't mean to rush you. Feel free to tell me your advice since there would be some design discussion.

Anyway, I understand your effort is volunteer based one but tell me if there's anything I can help.

@zackw
Copy link
Collaborator

zackw commented Apr 16, 2019

Release candidate wheels are now available for Mac and Linux at https://test.pypi.org/project/mecab-python3/0.996.2rc2/ , please test them. Thank you everyone for your patience. We plan to make a new official release in the next couple of weeks.

Windows wheels are in the works but I can't give any time frame for them, sorry.

@zackw
Copy link
Collaborator

zackw commented Apr 22, 2019

0.996.2 has been released with wheels for Mac and Linux. I am going to close this issue and make a new one specifically for Windows wheels.

@zackw zackw closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants