Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename handleTab to onTab #29

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Rename handleTab to onTab #29

merged 1 commit into from
Oct 23, 2017

Conversation

mxstbr
Copy link
Collaborator

@mxstbr mxstbr commented Oct 23, 2017

For the sake of API consistency with the DraftJS <Editor /> component it makes sense to rename handleTab to the (more expected) onTab.

This should resolve some confusion around using this library, as all functions now directly correspond with the editor props.

Closes #28

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.265% when pulling f6f122e on on-tab into ace811e on master.

@mxstbr mxstbr merged commit 9e973b2 into master Oct 23, 2017
@mxstbr mxstbr deleted the on-tab branch October 23, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename handleTab to onTab
2 participants