Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 'code' in hasSelectionInBlock (see react-draft-wysiwyg) #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lefnire
Copy link

@lefnire lefnire commented Jan 10, 2018

I'm new to Draft, I don't know if code-block is a standard and should be followed, or if you get to make your own or what. https://github.com/jpuri/react-draft-wysiwyg inserts code, so this adds support for that (alternatively ~currentBlock.getType().indexOf('code') in case other editors use codeblock or whatever).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.265% when pulling ebcd057 on lefnire:master into c219dc5 on SamyPesse:master.

@lefnire
Copy link
Author

lefnire commented Jan 10, 2018

Ah, <pre> maps to code-block, and <code> to code. So this PR should cover everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants