Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Words starting with z are most likely ignored #44

Closed
Samyak2 opened this issue Sep 5, 2022 · 2 comments · Fixed by #45
Closed

Words starting with z are most likely ignored #44

Samyak2 opened this issue Sep 5, 2022 · 2 comments · Fixed by #45
Labels
bug Something isn't working

Comments

@Samyak2
Copy link
Owner

Samyak2 commented Sep 5, 2022 •
edited
Loading

Clippy found a bug in:

toipe/src/textgen.rs

Line 78 in 3cb7e31

(b'a'..b'z').contains(&char)

The range should have been inclusive.

https://github.com/Samyak2/toipe/runs/8056437431?check_suite_focus=true#step:6:8
@Samyak2 Samyak2 added the bug Something isn't working label Sep 5, 2022
@nate-sys
Copy link
Contributor

nate-sys commented Sep 5, 2022

couldn't you just change the .. to a ..=?

@Samyak2
Copy link
Owner Author

Samyak2 commented Sep 5, 2022

Yes, that's the solution. I opened this issue so that I wouldn't forget it. PRs are always welcome though :)

@nate-sys nate-sys mentioned this issue Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include the letter z nate-sys/toipe
2 participants
@Samyak2 @nate-sys