Close some TODOs #39
Merged
Close some TODOs #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samyak2
reviewed
Jun 25, 2022
There was a problem hiding this comment.
The "reset cursor to whatever it was before Toipe was started." TODO is, from what I can tell, unfortunately impossible due to the limitations of escape sequences used to change the cursor shape, therefore removed. See this discussion on the neovim repo.
Ah I see, that's a shame.
Thank you for your contribution! I had one suggestion, but looks good otherwise.
Co-authored-by: Samyak Sarnayak <samyak201@gmail.com>
Samyak2
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes multiple TODOs.
The "reset cursor to whatever it was before Toipe was started." TODO is, from what I can tell, unfortunately impossible due to the limitations of escape sequences used to change the cursor shape, therefore removed. See this discussion on the neovim repo.