Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubber Tree without rubber #10

Merged
merged 5 commits into from
Aug 6, 2021
Merged

Conversation

longfangsong
Copy link
Collaborator

@longfangsong longfangsong commented Aug 4, 2021

This is the most f**king hard feature I add to this mod.

This pr adds rubber trees, which supposed to generate rubber which is a basic gradient of the indrusty system.

But after adding the tree without generating rubber, this pr is already this large. So I'll leave rubber generating part for next PR.

Part of #8.

@longfangsong
Copy link
Collaborator Author

/cc @zhoudian64

Copy link
Collaborator

@zhoudian64 zhoudian64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -80,29 +122,77 @@ object MagicCrystal : ModInitializer {
Registry.register(
Registry.ITEM,
Identifier(MOD_ID, "tin_ore"),
Item(Item.Settings().group(ItemGroup.MISC))
BlockItem(TIN_ORE_BLOCK, Item.Settings().group(ItemGroup.MISC))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add our own ItemGroup


1. Run client.
2. Create a new world (creative world).
3. Fly around to find a rubber tree.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some more remarkable picture for our featured creatures? And add some build option to control this.

I think that will help debugging/testing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some more remarkable picture for our featured creatures? And add some build option to control this.

I think that will help debugging/testing.

"build option" in JVM……Might be hard.

3. Fly around to find a rubber tree.
4. Dig all the logs and check whether the leaves break automatically and drop rubber tree sapling.
(You might be very unlucky that rubber tree sapling don't drop but in fact the mod works well, so you should replace this several times before report a bug).
5. Plant the sapling and wait it growing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually bone powder works!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If natual growing works, bone powder also works, but not vice versa.
MC is really strange……

]
}
]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a piece of shit!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it able to make a plugin, like UI setup tab in .net Desktop in Visual Studio?
like, list all options in table and let developer select using mouse.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it able to make a plugin, like UI setup tab in .net Desktop in Visual Studio?
like, list all options in table and let developer select using mouse.

You may try MCreator, however its 1.17 support is WIP, and it's in f**king Java.
I think since we need to generate document, we can develop a shared library to parse and edit these jsons.

@longfangsong longfangsong merged commit f95ce1c into San-Anti-Java:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants