Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: need to render comments #191

Closed
2 tasks done
Girishbari opened this issue Jan 17, 2024 · 5 comments · Fixed by #217
Closed
2 tasks done

Feat: need to render comments #191

Girishbari opened this issue Jan 17, 2024 · 5 comments · Fixed by #217
Assignees
@Girishbari
Labels
EASY Difficulty Level: Easy ⭐ enhancement Feature enhancement 🛠 goal: fix The label is related to fixing a bug SWOC S4 Social Winter of Code (S4) 2024 contribution tag

Comments

@Girishbari
Copy link
Contributor

Girishbari commented Jan 17, 2024 •
edited
Loading

What feature?

currently one can post comment and can get notified that comment is added but there is no way a user can see comments

Add screenshots

image

Record

  • I agree to follow this project's Code of Conduct
  • I want to work on this issue
@Girishbari Girishbari added SWOC S4 Social Winter of Code (S4) 2024 contribution tag ⭐ enhancement Feature enhancement labels Jan 17, 2024
@github-actions GitHub Actions
Copy link

Congratulations, @Girishbari! 🎉 Thank you for creating the issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

@Sanchitbajaj02
Copy link
Owner

@Girishbari User post visibility should be on /post/postId. On /feed user can not see the comments. You can implement the functionality on /post/postId.

Assigned to you.

@Sanchitbajaj02 Sanchitbajaj02 added EASY Difficulty Level: Easy 🛠 goal: fix The label is related to fixing a bug labels Jan 17, 2024
@Sanchitbajaj02
Copy link
Owner

@Girishbari what is the progress on this issue?

@Girishbari
Copy link
Contributor Author

had some work, will try for a pull request tonight

@Girishbari
Copy link
Contributor Author

feat: #217

@Sanchitbajaj02 Sanchitbajaj02 linked a pull request Jan 24, 2024 that will close this issue
feat: rendering the comments and pull requests for #191 #217
Merged
Sanchitbajaj02 pushed a commit that referenced this issue Jan 27, 2024
@Girishbari
feat: rendering the comments and pull requests for #191 (#217)
a89649f 
* fix: resolved delete handler bug

* feat: rendering the comments

* refactor: some code refactoring

* refactor: removed some consoles

* feat: rendering comments with necessary UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Girishbari Girishbari

Labels
EASY Difficulty Level: Easy ⭐ enhancement Feature enhancement 🛠 goal: fix The label is related to fixing a bug SWOC S4 Social Winter of Code (S4) 2024 contribution tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rendering the comments and pull requests for #191 Girishbari/palettegram
2 participants
@Girishbari @Sanchitbajaj02