feat: skeleton for posts #220
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @Sanchitbajaj02 on Vercel. @Sanchitbajaj02 first needs to authorize it. |
github-actions
bot
added
wait for reviewers
SWOC S4
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Girishbari! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
Sanchitbajaj02
added
⭐ enhancement
| whileInView={{ opacity: 1, y: 0 }} | ||
| viewport={{ once: true }} | ||
| transition={{ duration: 0.1, type: "spring", stiffness: 110 }} | ||
| <div |
There was a problem hiding this comment.
instead of remove, comment the functionality, we might need this later
There was a problem hiding this comment.
Yeah I would gladly add if needed I know framer-motion but the problem is sometimes that component renders and sometimes not and due to this I removed that animation to make stable user experience
There was a problem hiding this comment.
That is why I said, we might need later when we finish making the components
There was a problem hiding this comment.
added the changes
src/app/postSkeleton.tsx
Outdated
There was a problem hiding this comment.
It would be better to load it in the loading.tsx of the user instead of creating a file at /src/app
There was a problem hiding this comment.
but the Loader which is inside of Loading.tsx is being used in various places like buttons and all so adding the skeleton code will make things wrong
There was a problem hiding this comment.
what you can do is make a seperate loader file for /feed page in the /src/app/feed/loading.tsx
There was a problem hiding this comment.
added the changes
|
@Manishak798 LGTM Thanks for reviewing |
Related Issue
Feat : #144
Description
Added Skeleton Component for posts
Screenshots