fix: patch global scrollbar bug #250
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @Sanchitbajaj02 on Vercel. @Sanchitbajaj02 first needs to authorize it. |
github-actions
bot
added
wait for reviewers
SWOC S4
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Girishbari! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
WalkthroughThis update involves modifications to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/app/layout.tsx (1 hunks)
Additional comments: 4
src/app/layout.tsx (4)
- 51-56: The modifications to the
<html>and<body>tags, including the reordering of attributes and the application of classes for scrollbar customization, align with the PR's objective to fix the global scrollbar issue. This change should ensure that the custom scrollbar styling provided by Tailwind CSS is correctly applied across all specified browsers. However, it's important to verify that these changes do not introduce any accessibility or usability issues, especially for users relying on keyboard navigation or screen readers.- 54-54: The
suppressHydrationWarningattribute is used in the<html>tag. This is an unusual placement since this attribute is typically associated with suppressing hydration warnings in React components that might have differences between server-rendered and client-side content. Ensure that its usage here is intentional and does not inadvertently suppress important warnings that could help identify potential issues with mismatched server/client rendering.- 53-56: Applying the
poppinsFont.classNameto both the<html>and<body>tags, along with the scrollbar customization classes to the<html>tag, is a strategic approach to ensure consistent font and scrollbar styling across the application. This change is crucial for addressing the scrollbar issue and enhancing the overall user experience. However, it's recommended to test these changes across the specified browsers (Chrome, Safari, Microsoft Edge, and Brave) to confirm that the scrollbar behaves as expected without any unintended side effects.- 48-59: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [5-5]
The commented-out import statements for
react-toastifyand its CSS file, replaced by theToastercomponent fromsonner, indicate a change in the notification system used by the application. While this change is not directly related to the scrollbar issue, it's important to ensure that the newToastercomponent integrates well with the application and provides a comparable or improved user experience. Testing the notification functionality across different scenarios and browsers is recommended to confirm its effectiveness and user-friendliness.
Sanchitbajaj02
added
🪲 bug
* refactor: solved the bug mentioned in #246 * feat: replaced react-toastify with sonner lib (#242) * feat: new changes * feat: replaced react-toastify with sonner * feat: yarn file * refactor: added requested changes --------- Co-authored-by: Sanchit Bajaj <55249639+Sanchitbajaj02@users.noreply.github.com> * feat: Form validation (#243) * feat: add detailed footer section * fix: form-validation bug * fix: changed footer alignment (#239) * fix: patch global scrollbar bug (#250) * Random avatar generator for profiles #154 (#207) Co-authored-by: Sanchit Bajaj <55249639+Sanchitbajaj02@users.noreply.github.com> * refactor: patch navbar bug * refactor: patch navbar bug 2 --------- Co-authored-by: Sanchit Bajaj <55249639+Sanchitbajaj02@users.noreply.github.com> Co-authored-by: Monu <142221687+monoMonu@users.noreply.github.com> Co-authored-by: Kom Senapati <komnoob123@gmail.com> Co-authored-by: Amit Mishra <65525769+DaSeeker67@users.noreply.github.com>
* refactor: solved the bug mentioned in Sanchitbajaj02#246 * feat: replaced react-toastify with sonner lib (Sanchitbajaj02#242) * feat: new changes * feat: replaced react-toastify with sonner * feat: yarn file * refactor: added requested changes --------- Co-authored-by: Sanchit Bajaj <55249639+Sanchitbajaj02@users.noreply.github.com> * feat: Form validation (Sanchitbajaj02#243) * feat: add detailed footer section * fix: form-validation bug * fix: changed footer alignment (Sanchitbajaj02#239) * fix: patch global scrollbar bug (Sanchitbajaj02#250) * Random avatar generator for profiles Sanchitbajaj02#154 (Sanchitbajaj02#207) Co-authored-by: Sanchit Bajaj <55249639+Sanchitbajaj02@users.noreply.github.com> * refactor: patch navbar bug * refactor: patch navbar bug 2 --------- Co-authored-by: Sanchit Bajaj <55249639+Sanchitbajaj02@users.noreply.github.com> Co-authored-by: Monu <142221687+monoMonu@users.noreply.github.com> Co-authored-by: Kom Senapati <komnoob123@gmail.com> Co-authored-by: Amit Mishra <65525769+DaSeeker67@users.noreply.github.com>
Related Issue
Fix: #245
Description
Separated scrollbar class from body element to HTML element
Screenshots