-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: footer over-lapping issue resolve #263
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Sanchitbajaj02 on Vercel. @Sanchitbajaj02 first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @IrfanshaikH-7! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
WalkthroughThe recent updates focus on enhancing user interface elements within the application. A significant change has been made to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- src/components/core/trendingFeed/index.tsx (1 hunks)
- src/components/pages/user/index.tsx (1 hunks)
Additional comments: 2
src/components/core/trendingFeed/index.tsx (1)
- 7-7: The change from
fixed
tosticky
positioning with atop-24
offset for theTrendingFeed
component is a good approach to resolving the footer overlap issue. It ensures that the component remains accessible while scrolling, up to a certain point. The use of Tailwind CSS classes is correct and follows best practices. However, it's important to verify thez-10
z-index value in the context of the entire application to ensure it does not introduce any unintended layering issues with other components.src/components/pages/user/index.tsx (1)
- 20-20: Based on the description, increasing the vertical padding of the main container in the User component is a sensible approach to improving layout and spacing, potentially helping to resolve the footer overlap issue. Ensure that the implementation follows Tailwind CSS conventions and consider the impact of this increased padding on the overall layout across different screen sizes, to avoid introducing excessive whitespace on smaller devices.
LGTM, merging the PR |
Related Issue
issue #261
Description
Fixed the issue where footer was overlapping with treading posts components.
##Changes
Replace some tailwind class and adjusted consistence with other pages ..
Now the Trending-posts will not overlap instead if reaches to top of footer it'll scrolls with footer as footer is the bottom most element.