Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer over-lapping issue resolve #263

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

IrfanshaikH-7
Copy link
Contributor

Related Issue

issue #261

Description

Fixed the issue where footer was overlapping with treading posts components.

##Changes
Replace some tailwind class and adjusted consistence with other pages ..

Now the Trending-posts will not overlap instead if reaches to top of footer it'll scrolls with footer as footer is the bottom most element.

Copy link

vercel bot commented Feb 25, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @Sanchitbajaj02 on Vercel.

@Sanchitbajaj02 first needs to authorize it.

@github-actions github-actions bot added wait for reviewers SWOC S4 Social Winter of Code (S4) 2024 contribution tag labels Feb 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @IrfanshaikH-7! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

Copy link
Contributor

coderabbitai bot commented Feb 25, 2024

Walkthrough

The recent updates focus on enhancing user interface elements within the application. A significant change has been made to the TrendingFeed component, where its positioning has been shifted from fixed to sticky, accompanied by a vertical offset. Additionally, the User component received an adjustment in its layout, specifically in the padding of its main container, which has been increased to provide better spacing and organization of the elements within.

Changes

File Path Change Summary
.../core/trendingFeed/index.tsx Changed section element's className from fixed to sticky top-24.
.../pages/user/index.tsx Increased the main container's vertical padding from 4 to 8 units.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 377f2f2 and 99ac6ed.
Files selected for processing (2)
  • src/components/core/trendingFeed/index.tsx (1 hunks)
  • src/components/pages/user/index.tsx (1 hunks)
Additional comments: 2
src/components/core/trendingFeed/index.tsx (1)
  • 7-7: The change from fixed to sticky positioning with a top-24 offset for the TrendingFeed component is a good approach to resolving the footer overlap issue. It ensures that the component remains accessible while scrolling, up to a certain point. The use of Tailwind CSS classes is correct and follows best practices. However, it's important to verify the z-10 z-index value in the context of the entire application to ensure it does not introduce any unintended layering issues with other components.
src/components/pages/user/index.tsx (1)
  • 20-20: Based on the description, increasing the vertical padding of the main container in the User component is a sensible approach to improving layout and spacing, potentially helping to resolve the footer overlap issue. Ensure that the implementation follows Tailwind CSS conventions and consider the impact of this increased padding on the overall layout across different screen sizes, to avoid introducing excessive whitespace on smaller devices.

@Sanchitbajaj02 Sanchitbajaj02 added 🪲 bug Something isn't working 🛠 goal: fix The label is related to fixing a bug EASY Difficulty Level: Easy and removed wait for reviewers labels Feb 25, 2024
@Sanchitbajaj02 Sanchitbajaj02 linked an issue Feb 25, 2024 that may be closed by this pull request
2 tasks
@Sanchitbajaj02
Copy link
Owner

LGTM, merging the PR

@Sanchitbajaj02 Sanchitbajaj02 merged commit aba629c into Sanchitbajaj02:master Feb 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working EASY Difficulty Level: Easy 🛠 goal: fix The label is related to fixing a bug SWOC S4 Social Winter of Code (S4) 2024 contribution tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Fix footer overlapping bug
2 participants