fix: cookie issue fix by separating the cookie logic

[Sanchitbajaj02]

Related Issue

Closes #265

Description

cookie setting issue fixed

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
palettegram	✅ Ready (Inspect)	Visit Preview	Feb 29, 2024 7:05pm

[coderabbitai]

Walkthrough

The modifications primarily focus on refining the authentication process by adjusting where and how cookies are set for user authentication details. This initiative aims to resolve an issue where user authentication cookies were being set twice, leading to redundancy. The changes involve shifting the cookie setting logic from redux reducers to specific authentication components (login and register), enhancing the import method for a utility function, and removing redundant cookie-setting operations.

Changes

File Path	Change Summary
.../core/navbar/index.tsx	Removed unused import of userCollectionDB.
.../pages/auth/login/index.tsx	Added setCookie import and logic to set cookies post-login.
.../pages/auth/register/index.tsx	Added setCookie import and logic to set cookies post-registration.
.../pages/auth/verification/index.tsx	Updated useWindowSize import path.
.../reducers/authReducer.ts	Removed cookie setting logic from saveUserToStore function.

Assessment against linked issues

Objective	Addressed	Explanation
Bug: Cookie setting twice (#265)	✅	The removal of cookie setting logic from redux reducers and integrating it directly within the login and registration components directly addresses the issue of cookies being set twice, as it centralizes the cookie setting to a single point in the authentication flow, eliminating redundancy.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[github-actions]

Great job, @Sanchitbajaj02! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7d89954 and 78baefb.

Files selected for processing (5)

• src/components/core/navbar/index.tsx (1 hunks)
• src/components/pages/auth/login/index.tsx (2 hunks)
• src/components/pages/auth/register/index.tsx (2 hunks)
• src/components/pages/auth/verification/index.tsx (1 hunks)
• src/redux/reducers/authReducer.ts (2 hunks)

Additional comments: 8

src/redux/reducers/authReducer.ts (1)

• 1-7: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-34]

The removal of setCookie function calls from the saveUserToStore function aligns with best practices by keeping reducers pure and free of side effects. Ensure that the cookie setting logic has been correctly implemented in the respective components to maintain functionality.

src/components/pages/auth/verification/index.tsx (2)

• 8-8: The update to the import statement for useWindowSize reflects good maintenance practice, likely due to changes in the react-use library structure.
• 5-11: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [68-74]

Moving the setCookie logic into the component is a strategic improvement that directly addresses the issue of cookie duplication. Ensure that the cookies are set correctly based on the response payload and that this change does not introduce any unintended side effects.

src/components/core/navbar/index.tsx (1)

• 16-21: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The removal of the unused import userCollectionDB from @/types/auth is a good practice for code cleanliness and efficiency. Ensure that this import was indeed not used within the navbar component to prevent any unintended functionality loss.

src/components/pages/auth/login/index.tsx (2)

• 18-18: The addition of the setCookie import from "nookies" is correctly implemented to facilitate cookie setting within the component.
• 68-74: Implementing the logic to set cookies directly in the login component is a strategic improvement that addresses the issue of cookie duplication. Ensure that the cookies are set correctly based on the response payload and that this change does not introduce any unintended side effects.

src/components/pages/auth/register/index.tsx (2)

• 17-17: The addition of the setCookie import from "nookies" is correctly implemented to facilitate cookie setting within the component.
• 79-85: Implementing the logic to set cookies directly in the register component is a strategic improvement that addresses the issue of cookie duplication. Ensure that the cookies are set correctly based on the response payload and that this change does not introduce any unintended side effects.