Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated homepage to give more info about website #316

Merged
merged 4 commits into from
May 19, 2024

Conversation

harini-1597
Copy link
Contributor

@harini-1597 harini-1597 commented May 17, 2024

Related Issue

Fixes #285

Description

I feel that the website home page doesn't really tell much about what the website is for and only asks you to sign in leading to lesser user retention;
I would like the home-page scroll to offer some more information as user scrolls down:
-> What is Palettegram?
-> Who is Palettegram for?
-> Why Palettegram?
(and some other useful info...)

Screenshots

Here's a video preview of the proposed changes as discussed with @Sanchitbajaj02:

Screen.Recording.2024-05-17.at.11.14.26.AM.mov

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Enhanced user experience with motion effects on headings and paragraphs on the home page.
    • Improved text content to better communicate the platform's purpose and target audience.
  • Style

    • Updated image sources on the home page for a refreshed look.
    • Imported Google Fonts and added new CSS rules for enhanced styling.

Copy link

vercel bot commented May 17, 2024

@harini-1597 is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

The recent updates aim to improve the user experience on the home page by making changes such as updating image sources, incorporating motion effects on elements, adjusting text content, and refining layout styling. Furthermore, global styles have been enhanced by introducing a new Google Fonts import and adding extra CSS rules for a specific class, resulting in a more cohesive and visually appealing design.

Changes

Files Change Summary
.../home/index.tsx Updated image sources, added motion effects to elements, adjusted styling and text content in article sections.
.../styles/globals.css Added Google Fonts import and additional CSS rules for the .sub-section class.

Assessment against linked issues

Objective Addressed Explanation
Feat: add a gallery dashboard to show the features (Issue #285)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @harini-1597! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bf2ff2b and c8ec04a.
Files ignored due to path filters (3)
  • public/assets/imgA.png is excluded by !**/*.png, !**/*.png
  • public/assets/imgB.png is excluded by !**/*.png, !**/*.png
  • public/assets/imgC.png is excluded by !**/*.png, !**/*.png
Files selected for processing (2)
  • src/components/pages/home/index.tsx (4 hunks)
  • src/styles/globals.css (2 hunks)
Files skipped from review due to trivial changes (1)
  • src/styles/globals.css
Additional comments not posted (6)
src/components/pages/home/index.tsx (6)

102-108: Update image source to match new design requirements.


124-139: Ensure the new text aligns with the website's branding and messaging strategy.


171-171: This text effectively targets developers, aligning with the intended audience.


188-188: Verify that the new image source is correctly linked and optimized for web use.


213-213: Confirm that the image source /assets/imgC.png is correctly uploaded and accessible.

Verification successful

The image source /assets/imgC.png is correctly uploaded and accessible as public/assets/imgC.png.

  • The image file imgC.png was found in the public/assets/ directory.
  • The path /assets/imgC.png used in the code should be correct if the public directory is the root for serving static files.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Ensure the image source is accessible.

# Test: Check if the image exists in the assets directory.
fd 'imgC.png' src/assets/

Length of output: 124



Script:

#!/bin/bash
# Description: Ensure the image source is accessible.

# Test: Check if the image exists in the repository.
fd 'imgC.png'

Length of output: 36


Line range hint 235-249: The updated section title and description are engaging and promote community interaction.

@harini-1597 harini-1597 changed the title chore: homepage update Fix: Updated homepage to give more info about website May 17, 2024
@github-actions github-actions bot added the title needs formatting Title of issue or pull request does not match the guidelines label May 17, 2024
@harini-1597 harini-1597 changed the title Fix: Updated homepage to give more info about website fix: Updated homepage to give more info about website May 17, 2024
@github-actions github-actions bot removed the title needs formatting Title of issue or pull request does not match the guidelines label May 17, 2024
@@ -1,6 +1,7 @@
@tailwind base;
@tailwind components;
@tailwind utilities;
@import url('https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poppins is already configured in the src/app/layout.tsx. Please use that as this method is redundent

@@ -41,6 +42,9 @@ body {
.custom-shadow {
filter: drop-shadow(0 5px 150px rgba(182, 0, 85, 0.75));
}
.sub-section {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this added?

}}
className="text-3xl md:text-6xl text-center font-extrabold tracking-wide text-black dark:text-white md:text-right"
>
What is <br /> Palettegram?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add br tag. Please remove it

@@ -121,7 +232,7 @@ function HomePage({ accountId }: { accountId: string | undefined }) {
}}
className="text-3xl md:text-6xl text-center font-extrabold tracking-wide text-black dark:text-white md:text-right"
>
Who is <br /> Palettegram for?
Create, Showcase <br /> Collaborate
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add br tag. Please remove it

@Sanchitbajaj02 Sanchitbajaj02 added ⭐ enhancement Feature enhancement EASY Difficulty Level: Easy level1 10 points gssoc GSSOC'24 Required Label ✨ goal: improve interface and removed wait for reviewers labels May 17, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c8ec04a and dcc5857.
Files selected for processing (1)
  • src/components/pages/home/index.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/components/pages/home/index.tsx

@harini-1597
Copy link
Contributor Author

@Sanchitbajaj02 I've made the changes requested

@yashd-dev
Copy link
Collaborator

Hey there, the illustrations used do not have a transparent background which makes it look out of place in dark mode, kindly use transparent illustrations.

image

@harini-1597
Copy link
Contributor Author

Are these okay?
Or would you like them all gray? Personally, I feel this adds more color to the website, what do you think?

Screen Shot 2024-05-19 at 11 09 55 AM

Screen Shot 2024-05-19 at 11 10 12 AM

Copy link
Owner

@Sanchitbajaj02 Sanchitbajaj02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sanchitbajaj02 Sanchitbajaj02 merged commit 33f1791 into Sanchitbajaj02:master May 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EASY Difficulty Level: Easy ⭐ enhancement Feature enhancement ✨ goal: improve interface gssoc GSSOC'24 Required Label level1 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add a gallery dashboard to show the features
3 participants