-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated homepage to give more info about website #316
Conversation
@harini-1597 is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent updates aim to improve the user experience on the home page by making changes such as updating image sources, incorporating motion effects on elements, adjusting text content, and refining layout styling. Furthermore, global styles have been enhanced by introducing a new Google Fonts import and adding extra CSS rules for a specific class, resulting in a more cohesive and visually appealing design. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @harini-1597! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
public/assets/imgA.png
is excluded by!**/*.png
,!**/*.png
public/assets/imgB.png
is excluded by!**/*.png
,!**/*.png
public/assets/imgC.png
is excluded by!**/*.png
,!**/*.png
Files selected for processing (2)
- src/components/pages/home/index.tsx (4 hunks)
- src/styles/globals.css (2 hunks)
Files skipped from review due to trivial changes (1)
- src/styles/globals.css
Additional comments not posted (6)
src/components/pages/home/index.tsx (6)
102-108
: Update image source to match new design requirements.
124-139
: Ensure the new text aligns with the website's branding and messaging strategy.
171-171
: This text effectively targets developers, aligning with the intended audience.
188-188
: Verify that the new image source is correctly linked and optimized for web use.
213-213
: Confirm that the image source/assets/imgC.png
is correctly uploaded and accessible.Verification successful
The image source
/assets/imgC.png
is correctly uploaded and accessible aspublic/assets/imgC.png
.
- The image file
imgC.png
was found in thepublic/assets/
directory.- The path
/assets/imgC.png
used in the code should be correct if thepublic
directory is the root for serving static files.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure the image source is accessible. # Test: Check if the image exists in the assets directory. fd 'imgC.png' src/assets/Length of output: 124
Script:
#!/bin/bash # Description: Ensure the image source is accessible. # Test: Check if the image exists in the repository. fd 'imgC.png'Length of output: 36
Line range hint
235-249
: The updated section title and description are engaging and promote community interaction.
src/styles/globals.css
Outdated
@@ -1,6 +1,7 @@ | |||
@tailwind base; | |||
@tailwind components; | |||
@tailwind utilities; | |||
@import url('https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poppins is already configured in the src/app/layout.tsx. Please use that as this method is redundent
src/styles/globals.css
Outdated
@@ -41,6 +42,9 @@ body { | |||
.custom-shadow { | |||
filter: drop-shadow(0 5px 150px rgba(182, 0, 85, 0.75)); | |||
} | |||
.sub-section { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this added?
src/components/pages/home/index.tsx
Outdated
}} | ||
className="text-3xl md:text-6xl text-center font-extrabold tracking-wide text-black dark:text-white md:text-right" | ||
> | ||
What is <br /> Palettegram? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add br tag. Please remove it
src/components/pages/home/index.tsx
Outdated
@@ -121,7 +232,7 @@ function HomePage({ accountId }: { accountId: string | undefined }) { | |||
}} | |||
className="text-3xl md:text-6xl text-center font-extrabold tracking-wide text-black dark:text-white md:text-right" | |||
> | |||
Who is <br /> Palettegram for? | |||
Create, Showcase <br /> Collaborate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add br tag. Please remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/pages/home/index.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/components/pages/home/index.tsx
@Sanchitbajaj02 I've made the changes requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Fixes #285
Description
I feel that the website home page doesn't really tell much about what the website is for and only asks you to sign in leading to lesser user retention;
I would like the home-page scroll to offer some more information as user scrolls down:
-> What is Palettegram?
-> Who is Palettegram for?
-> Why Palettegram?
(and some other useful info...)
Screenshots
Here's a video preview of the proposed changes as discussed with @Sanchitbajaj02:
Screen.Recording.2024-05-17.at.11.14.26.AM.mov
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style