-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Security Update - Password Criteria Increased #325
Conversation
Update the @types/react and @types/node dependencies to their latest versions. This ensures compatibility with the latest React and Node.js features and typings.
…aracters The password validation regex has been updated to allow additional special characters: !, #, $, %, ^, &, *, -, +, =. This ensures that users can create stronger passwords with a wider range of special characters. fixes Sanchitbajaj02#314
…racters (@, _, !, #, $, %, ^, &) fixes Sanchitbajaj02#314
@JuanPabloDiaz is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @JuanPabloDiaz! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
WalkthroughThe recent updates to the registration page involve enhancing the password validation mechanism. The password length requirement has been extended from 6-16 to 6-24 characters, and additional special characters (@_!#$%^&) are now permitted. A new regex pattern has been introduced to disallow certain special characters, ensuring passwords meet the updated criteria. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
appwrite-gen/package.json
is excluded by!**/*.json
yarn.lock
is excluded by!**/*.lock
,!**/*.lock
Files selected for processing (1)
- src/components/pages/auth/register/index.tsx (2 hunks)
Additional comments not posted (2)
src/components/pages/auth/register/index.tsx (2)
21-22
: Updated regular expressions for password validation look correct and align with the PR objectives.
60-62
: The password length validation correctly checks for the new range of 6 to 24 characters.
@JuanPabloDiaz please fix the one which is raised by Coderabbit, rest is good |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/pages/auth/register/index.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/components/pages/auth/register/index.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
fixes #314
Description
@, _, !, #, $, %, ^, &
Screenshots
Summary by CodeRabbit
New Features
Bug Fixes