feat: 404 not found page style improved #354
Conversation
|
@RamakrushnaBiswal is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
title needs formatting
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @RamakrushnaBiswal! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
WalkthroughThe recent updates to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
RamakrushnaBiswal
changed the title
github-actions
bot
removed
the
title needs formatting
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
public/assets/404.pngis excluded by!**/*.png,!**/*.png
Files selected for processing (2)
- src/app/[others]/page.css (1 hunks)
- src/app/[others]/page.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- src/app/[others]/page.css
Additional comments not posted (3)
src/app/[others]/page.tsx (3)
12-20: TheCustom404component is well-structured and uses the imported assets correctly.
5-5: Import statement forpage.csslooks correct.Verification successful
The
page.cssfile exists in thesrc/app/[others]/directory, and the import path insrc/app/[others]/page.tsxcorrectly references this file.
src/app/[others]/page.tsx:import './page.css';Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the page.css file in the project. # Test: Check if the CSS file exists. Expect: The file should exist. if [ -f "./page.css" ]; then echo "CSS file exists." else echo "CSS file does not exist." fiLength of output: 82
Script:
#!/bin/bash # Description: Search for the page.css file in the project directory. # Test: Use fd to find the page.css file. Expect: The file should be found somewhere in the project. fd page.cssLength of output: 39
Script:
#!/bin/bash # Description: Verify the import path in src/app/[others]/page.tsx. # Test: Check if the import path in src/app/[others]/page.tsx correctly references the page.css file. grep "import './page.css';" src/app/[others]/page.tsxLength of output: 84
4-4: Import statement forNotFoundPiclooks correct.Verification successful
The image file
public/assets/404.pngexists in the repository. The import statement insrc/app/[others]/page.tsxis correct.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the 404.png image in the public assets directory. # Test: Check if the image file exists. Expect: The file should exist. if [ -f "/public/assets/404.png" ]; then echo "Image file exists." else echo "Image file does not exist." fiLength of output: 98
Script:
#!/bin/bash # Description: Search for the 404.png image file within the repository to determine its correct location. # Test: Use fd to find the 404.png file. Expect: The file should be found somewhere in the repository. fd 404.pngLength of output: 34
Script:
#!/bin/bash # Description: Verify the existence of the 404.png image in the public assets directory using the correct relative path. # Test: Check if the image file exists. Expect: The file should exist. if [ -f "public/assets/404.png" ]; then echo "Image file exists." else echo "Image file does not exist." fiLength of output: 81
|
This looks good but on mobile, it's too small. Just on mobile make it full width. |
|
|
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/app/[others]/page.tsx (1 hunks)
Additional context used
Biome
src/app/[others]/page.tsx
[error] 13-13: Avoid the words "image", "picture", or "photo" in img element alt text. (lint/a11y/noRedundantAlt)
Screen readers announce img elements as "images", so it is not necessary to redeclare this in alternative text.
[error] 14-14: Avoid passing children using a prop (lint/correctness/noChildrenProp)
The canonical way to pass children in React is to use JSX elements
Sanchitbajaj02
added
⭐ enhancement
Related Issue
fixes #350
Description
404 page redesigned like add some pic
Screenshots
Summary by CodeRabbit
New Features
Enhancements