forked from noaa-ocs-modeling/OCSMesh
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/set boundaries in global mesh #3
Open
SanderHulst
wants to merge
11
commits into
main
Choose a base branch
from
feature/set_boundaries_in_global_mesh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return segments | ||
|
||
|
||
def get_boundary_data(mesh): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanderHulst can you please explain if and how does this get_boundary_data
function differ from the existing functionality in mesh/mesh.py
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running ADCIRC on a global mesh that was generated with OceanMesh2D. They have no boundary information which is apparently acceptable for ADCIRC. It is a problem when I regrid the unstructured results to a regular mesh because there is no notion about what is land or sea.
The biggest problem to work around was that the class Hull appears to have problems with the cyclic grid
mesh.hull.rings.exterior()
fails. I did not investigate why.I worked around the problem by:
get_boundary_segments
to get all coastal and interior boundariesOne of the first I would like to is to be able to modify the global mesh. For instance, it has Lake Ijsselmeer in the Netherlands as open water and that is not correct.
It would be interesting to see if we can get OCSMesh as far as to be able to create a new mesh, based on an existing global mesh.