-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malloc with varsize (option 1) implementation #1082
base: main
Are you sure you want to change the base?
Conversation
@davidozog @stewartl318 - Does this implementation look correct to you? |
The implementation looks right, but I don't like calloc_varsize. I though we decided that size should be the same for all PEs, and global_max_count is the same for all PEs, but that my_count could be different for each PE. |
@stewartl318 - thanks for your comments. You do have to pass One update is, I do see issues with this code for the subsequent symmetric allocations. I think the reason is |
I was imprecise. My point is that all PEs should have my_size == global_max_size. I cannot think of a counterexample. Therefore the function does not need both. Does shmem_calloc have a rule that size and count have to be the same on all PEs? Or is the rule that size*count must be the same on all PEs? |
@stewartl318 - By any chance, are you looking at the first commit only? Please check the latest commit or overall changes. The first commit was done some time back, but I have updated that before opening this PR. |
Blush. Yes Wasi, I was not looking at the latest version. I am ok with the newest one! |
This is a test PR for malloc varsize implementation with the following syntax: