You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes#41
Mixins will no longer be able to extend other mixins (Rather the super mixin should be specified in an on clause). This breaking change is already on flutter's master channel, which is causing build errors when depending on this library. dart-lang/sdk#48167
This change makes the mixin clause longer for many of the classes, but at least the tests seem to still pass. Other than one test which I'm assuming is related to this issue, which is already resolved on dart's master channel. dart-lang/sdk@abedfaf
Done, everything works, except test/src/task_test.dart: Task run fails. I'm not 100% sure why, but likely because of the dart-sdk issue I linked. I know there have been some changes related to futures in the dart sdk. The analyzer thinks that it is the right type if I hover over it, but I guess the compiled test has different behavior than the static analysis.
Fix for the dart sdk Future issue is in the master channel now.
I've tested with the dart sdk in flutter's master, beta, and stable channel, and all of the tests pass.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Mixins will no longer be able to extend other mixins (Rather the super mixin should be specified in an on clause). This breaking change is already on flutter's master channel, which is causing build errors when depending on this library.
dart-lang/sdk#48167
This change makes the mixin clause longer for many of the classes, but at least the tests seem to still pass. Other than one test which I'm assuming is related to this issue, which is already resolved on dart's master channel.
dart-lang/sdk@abedfaf