-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pokeapi example to riverpod v2 #99
Merged
SandroMaglione
merged 10 commits into
SandroMaglione:main
from
utamori:update-pokeapi-example-to-riverpod-v2
May 4, 2023
Merged
Update pokeapi example to riverpod v2 #99
SandroMaglione
merged 10 commits into
SandroMaglione:main
from
utamori:update-pokeapi-example-to-riverpod-v2
May 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandroMaglione
requested changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some updates for pure fp, let me know if you need any clarification
example/pokeapi_functional/lib/controllers/pokemon_provider.dart
Outdated
Show resolved
Hide resolved
SandroMaglione
added
documentation
Improvements or additions to documentation
refactoring
No change in functionality, but rewrite of some code
labels
Mar 15, 2023
@utamori any update on this PR? Would you have some time to address the comments? |
@utamori do you think this is ready? |
SandroMaglione
force-pushed
the
update-pokeapi-example-to-riverpod-v2
branch
from
May 4, 2023 16:22
4dc7ed3
to
4c6db23
Compare
SandroMaglione
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
refactoring
No change in functionality, but rewrite of some code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I updated the example using the Pokemon API as it was outdated.
Please let me know if there are any mistakes in the usage of fpdart.