Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pokeapi example to riverpod v2 #99

Conversation

utamori
Copy link
Contributor

@utamori utamori commented Mar 14, 2023

Hello, I updated the example using the Pokemon API as it was outdated.
Please let me know if there are any mistakes in the usage of fpdart.

  • update freezed version
  • update riverpod v2 and use riverpod_generator
  • migrate all model to freezed class
  • migrate RequestStatus to AsyncValue
  • migrate StateNotifier to AsyncNotifier

Copy link
Owner

@SandroMaglione SandroMaglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates for pure fp, let me know if you need any clarification

example/pokeapi_functional/lib/api/fetch_pokemon.dart Outdated Show resolved Hide resolved
example/pokeapi_functional/lib/main.dart Show resolved Hide resolved
@SandroMaglione SandroMaglione added documentation Improvements or additions to documentation refactoring No change in functionality, but rewrite of some code labels Mar 15, 2023
@SandroMaglione
Copy link
Owner

@utamori any update on this PR? Would you have some time to address the comments?

@SandroMaglione
Copy link
Owner

@utamori do you think this is ready?

@SandroMaglione SandroMaglione force-pushed the update-pokeapi-example-to-riverpod-v2 branch from 4dc7ed3 to 4c6db23 Compare May 4, 2023 16:22
@SandroMaglione SandroMaglione merged commit 38436a0 into SandroMaglione:main May 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactoring No change in functionality, but rewrite of some code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants