Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with any modern version of Node.js #196

Open
ghost opened this issue Mar 24, 2017 · 2 comments
Open

Does not work with any modern version of Node.js #196

ghost opened this issue Mar 24, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 24, 2017

Any recommendation for a project compatible with "node-mysql-libmysqlclient" that will work with a current version of Node.js?

@abhisekdg
Copy link

abhisekdg commented Apr 11, 2017

Node Version - 6.10.2 ( Previously working fine with v0.10.26)
NPM version - 3.10.10
OS - MacOS Sierra 10.12.4

@https://travis-ci.org/Sannis/node-mysql-libmysqlclient/jobs/194103714

var mysqllibclient = require('mysql-libmysqlclient'); ( 1.5.2)

After upgrading the node version to latest, it started throwing error.

MysqlConnectionQueued.prototype = new bindings.MysqlConnection();
TypeError: Cannot read property 'MysqlConnection' of null

Please can anyone suggest how it be supported in latest version of node ??

@Compro-Prasad
Copy link

Compro-Prasad commented Jan 13, 2018

I switched to v6.10.2 but no noticeable change in the build errors. Given I have gcc (GCC) 7.2.1 20171224 might be the problem which throws some nice and overlooked errors. Given I have a long list of errors I am addressing only a few:

../node_modules/nan/nan.h:761:22: error: ‘GetCurrent’ is not a member of ‘v8::Context’
         v8::Context::GetCurrent()->Global()
                      ^~~~~~~~~~
../node_modules/nan/nan.h: In member function ‘void NanAsyncWorker::SavePersistent(const char*, v8::Local<v8::Object>&)’:
../node_modules/nan/nan.h:181:38: error: ‘NewSymbol’ is not a member of ‘v8::String’
 #define NanSymbol(value) v8::String::NewSymbol(value)
                                      ^
../node_modules/nan/nan.h:808:17: note: in expansion of macro ‘NanSymbol’
     handle->Set(NanSymbol(key), obj);
                 ^~~~~~~~~
../node_modules/nan/nan.h: In member function ‘v8::Local<v8::Object> NanAsyncWorker::GetFromPersistent(const char*)’:
../node_modules/nan/nan.h:181:38: error: ‘NewSymbol’ is not a member of ‘v8::String’
 #define NanSymbol(value) v8::String::NewSymbol(value)
                                      ^
../node_modules/nan/nan.h:815:24: note: in expansion of macro ‘NanSymbol’
     return handle->Get(NanSymbol(key)).As<v8::Object>();
                        ^~~~~~~~~
../node_modules/nan/nan.h:815:53: error: expected primary-expression before ‘>’ token
     return handle->Get(NanSymbol(key)).As<v8::Object>();
                                                     ^
../node_modules/nan/nan.h:815:55: error: expected primary-expression before ‘)’ token
     return handle->Get(NanSymbol(key)).As<v8::Object>();
                                                       ^
../node_modules/nan/nan.h: In member function ‘virtual void NanAsyncWorker::HandleErrorCallback()’:
../node_modules/nan/nan.h:837:42: error: ‘New’ is not a member of ‘v8::String’
         v8::Exception::Error(v8::String::New(errmsg))
                                          ^~~
../node_modules/nan/nan.h: In function ‘bool _NanGetExternalParts(v8::Handle<v8::Value>, const char**, size_t*)’:
../node_modules/nan/nan.h:1005:12: error: ‘class v8::String’ has no member named ‘IsExternalAscii’; did you mean ‘IsExternal’?
   if (str->IsExternalAscii()) {
            ^~~~~~~~~~~~~~~
            IsExternal
../node_modules/nan/nan.h:1006:23: error: ‘ExternalAsciiStringResource’ in ‘class v8::String’ does not name a type
     const v8::String::ExternalAsciiStringResource* ext;
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1007:5: error: ‘ext’ was not declared in this scope
     ext = str->GetExternalAsciiStringResource();
     ^~~
../node_modules/nan/nan.h:1007:5: note: suggested alternative: ‘exit’
     ext = str->GetExternalAsciiStringResource();
     ^~~
     exit
../node_modules/nan/nan.h:1007:16: error: ‘class v8::String’ has no member named ‘GetExternalAsciiStringResource’; did you mean ‘GetExternalStringResource’?
     ext = str->GetExternalAsciiStringResource();
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                GetExternalStringResource
../node_modules/nan/nan.h: In instantiation of ‘void NanDisposePersistent(v8::Persistent<T, v8::NonCopyablePersistentTraits<T> >&) [with T = v8::Object]’:
../node_modules/nan/nan.h:786:44:   required from here
../node_modules/nan/nan.h:394:12: error: ‘class v8::Persistent<v8::Object>’ has no member named ‘Clear’
     handle.Clear();
     ~~~~~~~^~~~~
make: *** [mysql_bindings.target.mk:99: Release/obj.target/mysql_bindings/src/mysql_bindings.o] Error 1
make: Leaving directory '/home/compro/Downloads/github.com/Sannis/node-mysql-libmysqlclient/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2

The build is done after checking out to v1.6.0 of mysql-libmysqlclient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants