Pre-requisites script #72
Conversation
This script checks if the needed libraries and packages are installed, so our tool can run without errors.
XhorxhinaT
requested review from
ankushshr1993,
boxrhcp,
eltalkarim,
SantoshDhirwani and
ulalaa14
I still got to add the path of Template#61 -TODO after I have the script. Thinking a way to control the final echo when they all are installed (&&)=true or with (-o) =true
prerequisites.sh
Outdated
| fi | ||
|
|
||
| echo "" | ||
| cd cp_ws_1920/bin |
There was a problem hiding this comment.
why wrong path?
There was a problem hiding this comment.
and what comment did i left out? :/
There was a problem hiding this comment.
@boxrhcp wrong path? why is bin not undeer cp_ws
There was a problem hiding this comment.
I get the following errors.
bin is under cp_ws but im running the script inside cp_ws folder.
There was a problem hiding this comment.
There was a problem hiding this comment.
@boxrhcp gracias
No, your branch was behind the master so I just brought it on the same level as master without losing your changes, or else your script would not be able to find my scripts from #61. |
The last ToDo also runs well
There was a problem hiding this comment.
Now it's finished! Approve please @boxrhcp @ulalaa14 @santosh-dhirwani @ankushshr1993
|
Did you test it? the script is under /bin not in the base directory and is not checking if it worked or not :/ |
yes i did, santosh part worked, but caaliper didn't, and that comes because the script in my branch ended somehow under bin, which means, I have to refix caliper, or move the script. Your want prereq our of bin right? |
prereq.sh is out of bin now and caliper and template should work
|
As a side note: pip install pandas doesn't work for mac (at least it didn't work for me). So my question is that will these pre-requisites work for all types of operating systems? If not, we must mention it clearly in the readme. |
|
@santosh-dhirwani it looks like it works for me, and I have mac. Maybe you should upgrade your pip or use instead pip3. It depends on the python version u have installed |
|
Okay, great. I didn't check that on mac because I also switched to working in a VM (Ubuntu) recently. |
This script checks if the needed libraries and packages are installed, so our tool can run without errors.
Description
We need to ease the installation of the tool to the user. We are already installing libraries and dependencies and we need to take care of them to facilitate the installation of the user.
We need a script that:
Checks that Google SDK is installed, if not print a link to show where to download it / how to install it. If it is, configure the project written by the user in the config file.
Check if geth and puppeth(docker also needed to be installed) are installed, if not print a link to show how to install it.
Check if jq (used in the SUT script) is installed, if not print a link to show how to install it.
Check if npm is installed. If not print a link how to install it.
Check if caliper is installed under /bin. If not, it will be installed with npm.
Run caliper bind to configure ethereum.
Execute the template creation script #61
If possible in this script, check that the python libraries needed are installed. If possible find an easy way to install these libraries. If it is not possible it should be enough with checking if these are installed or not.
Related Issue
Related to
#30
Types of changes
Checklist contributor:
The code of the script runs without any errors (error handling correctly used)
The code should print clear steps of how to install or at least show a link with clear documentation of how to install what is needed.
If everything is installed, show a message that dependencies are fulfilled.
If after running the script everything is fulfilled, main.py must be able to run correctly without dependencies errors