Fix savefile import DbConcurrencyException #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
If a save import took a long time, the client would re-call `/tool/auth` again before receiving a response.. This would trigger another save import while the existing one was running and lead to a DbConcurrencyException. This PR: - Adds a locking mechanism by setting a string derived from the account ID in Redis - If a subsequent request is received, and a matching ID string is in Redis, no import is attempted and the Task is simply to wait until this key disappears - Also converts `BaasRequestHelper` to use Redis to cache the jwks, thus making the main application truly stateless again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a save import took a long time, the client would re-call
/tool/authagain before receiving a response.. This would trigger another save import while the existing one was running and lead to a DbConcurrencyException.This PR:
BaasRequestHelperto use Redis to cache the jwks, thus making the main application truly stateless again.