Improve yield projection #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id and carry feature has been removed
* calculate interest only for past days but at least for 1 day * avoid pre-settled yield reduction for loans repaid on the same day * patch tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yield settlement uses only past days.
Loan interest days use past days, but not less than 1. A new loan will have 1st day interest still due but the following incomplete days will not be counted. - This is to reduce complexity the previous method of using the ceil of days would create while the yield settlement uses only past days.
Repaying a loan on the same unix day will not reduce pre-settled yield as the loan did not contribute to yield settlement yet.
Reference: Fix-review WP-M1.