Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clicking on About does nothing. #127

Closed
Kamlesh72 opened this issue Oct 18, 2022 · 17 comments · Fixed by #167
Closed

[BUG] Clicking on About does nothing. #127

Kamlesh72 opened this issue Oct 18, 2022 · 17 comments · Fixed by #167
Assignees
Labels
bug 🐛 Issues/Pull Requests reporting/fixing a bug duplicate This issue or pull request already exists hacktoberfest Issues/Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Milestone

Comments

@Kamlesh72
Copy link

Describe the bug

When we click on Home, Contribute, Download etc.. it goes to specific section. But when we click on About, nothing happens.
It should take us to About section.

Steps To Reproduce

  1. Go to Home page
  2. Click About

Expected Behavior

It should take us on "More Information About Drifty"

Operating System

MacOS

Application Version

v1.2.0

Screenshots

No response

Additional information

No response

@Kamlesh72 Kamlesh72 added the bug 🐛 Issues/Pull Requests reporting/fixing a bug label Oct 18, 2022
@Kamlesh72
Copy link
Author

Pull request #128

@SaptarshiSarkar12
Copy link
Owner

@Kamlesh72 As you have opened a duplicate issue of #101, you need to wait for @i-ujjwaljha to respond. If @i-ujjwaljha does not respond within a few days (~2 -3 days maximum), I shall review your PR (#128).

@SaptarshiSarkar12 SaptarshiSarkar12 added the duplicate This issue or pull request already exists label Oct 18, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 linked a pull request Oct 18, 2022 that will close this issue
@Kamlesh72
Copy link
Author

Kamlesh72 commented Oct 19, 2022

@SaptarshiSarkar12 Ya sure. Actually I didn't know about that, So I made a duplicate PR.
Well if he doesn't respond I would also like to add an About Section with more Info.

@SaptarshiSarkar12 SaptarshiSarkar12 linked a pull request Oct 24, 2022 that will close this issue
@sharvit18
Copy link

assign it to me

@SaptarshiSarkar12
Copy link
Owner

assign it to me

Ya sure @Luciferr-18 .

@SaptarshiSarkar12
Copy link
Owner

As @sharvit18 no longer wants to work on it as he is busy, so, I am unassigning @sharvit18. If anyone wishes to work on it, he/she may comment below.

@anantnipunge
Copy link
Contributor

I'm availabel to work on it please assign me this issue @SaptarshiSarkar12 . Please add hacktoberfest label.

@anantnipunge
Copy link
Contributor

anantnipunge commented Oct 28, 2022

Also please tell me exactly what should i add in about section @SaptarshiSarkar12

@SaptarshiSarkar12
Copy link
Owner

Also please tell me exactly what should i add in about section @SaptarshiSarkar12

The about page will contain my GitHub readme along with my avatar.
@anantnipunge

@anantnipunge
Copy link
Contributor

Ya okay working on it. I will submit it soon

@anantnipunge
Copy link
Contributor

anantnipunge commented Oct 28, 2022 via email

@anantnipunge
Copy link
Contributor

Hello @SaptarshiSarkar12 should i create new div for about page. Or should i only redirect to the readme.md on click about

@SaptarshiSarkar12
Copy link
Owner

Hello @SaptarshiSarkar12 should i create new div for about page. Or should i only redirect to the readme.md on click about

Yes, create a new div. But, how about creating separate pages for each nav elements (including the about section)? This may decrease load time of the website. You may do so using another issue.

@anantnipunge
Copy link
Contributor

anantnipunge commented Oct 28, 2022

Okay let me do once. Then you can review it. If it looks good then i will push the code. Otherwise, will work on same section by using another way.

Okay?? @SaptarshiSarkar12

@SaptarshiSarkar12
Copy link
Owner

Okay let me do once. Then you can review it. If it looks good then i will push the code. Otherwise, will work on same section by using another way.

Okay?? @SaptarshiSarkar12

ok @anantnipunge

@anantnipunge
Copy link
Contributor

i have created the About section please check PR #167 @SaptarshiSarkar12 .

@SaptarshiSarkar12 SaptarshiSarkar12 linked a pull request Oct 29, 2022 that will close this issue
@anantnipunge
Copy link
Contributor

i have created new issue #169 please assign me this issue. @SaptarshiSarkar12

@SaptarshiSarkar12 SaptarshiSarkar12 added the Website 🌐 Issues/Pull Requests regarding Website label Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added this to the Drifty v1.3.0 milestone Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues/Pull Requests reporting/fixing a bug duplicate This issue or pull request already exists hacktoberfest Issues/Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
Status: Done
4 participants