-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add a feature to update Drifty #217
Comments
If anyone wants to work on this issue, please comment your name here and I shall assign you. |
i want to work in this issue |
Sure @Sakshikumari28 , you can work on this issue. I am assigning you with the task. |
@Sakshikumari28 Have you started working on this issue? Are you facing any problems? Let me know. |
I'm setting of the project in my local environment
…On Wed, 5 Jul, 2023, 1:51 pm Saptarshi Sarkar, ***@***.***> wrote:
@Sakshikumari28 <https://github.com/Sakshikumari28> Have you started
working on this issue? Are you facing any problems? Let me know.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZWYO2XFHEWICP6BPH4PVG3XOUP2DANCNFSM6AAAAAAZSRSZUA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Great 👍 @Sakshikumari28 |
@Sakshikumari28 What is your progress on this issue? |
@Sakshikumari28 Please respond. |
Here's what I want to do:
But I can't understand how I'm gonna call the API from Java. I've never worked with API's using Java as a back-end before, so can anyone help me / link me to a resource where I can get the instructions or how to call the API properly for this use case? |
@sayande717 The update flag should be - -u/-update
+ -u/--update and how are you going to implement the new code, that is, how is the new version going to replace the old one? |
@sayande717 After we get the tag_name from the api, we can check if that matches or is greater or smaller with respect to the user's Drifty version. There is a |
Sorry for the late reply sir I tried but I wasn't able to do this task
assigned to me
I apologize for that .you can assign to some other
On Mon, 10 Jul, 2023, 12:51 pm Saptarshi Sarkar, ***@***.***>
wrote:
… I'm setting of the project in my local environment
… <#m_1817591701436097688_m_-1662355819554228259_m_7150549713078310479_>
On Wed, 5 Jul, 2023, 1:51 pm Saptarshi Sarkar, *@*.*> wrote:
@Sakshikumari28 <https://github.com/Sakshikumari28>
https://github.com/Sakshikumari28 <https://github.com/Sakshikumari28> Have
you started working on this issue? Are you facing any problems? Let me
know. — Reply to this email directly, view it on GitHub <#217 (comment)
<#217 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZWYO2XFHEWICP6BPH4PVG3XOUP2DANCNFSM6AAAAAAZSRSZUA
<https://github.com/notifications/unsubscribe-auth/AZWYO2XFHEWICP6BPH4PVG3XOUP2DANCNFSM6AAAAAAZSRSZUA>
. You are receiving this because you were mentioned.Message ID: _@***.**_>
@Sakshikumari28 <https://github.com/Sakshikumari28> What is your progress
on this issue?
@Sakshikumari28 <https://github.com/Sakshikumari28> Please respond.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZWYO2QUQPFDVTWAX5CJZT3XPOUQZANCNFSM6AAAAAAZSRSZUA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It's okay, no problem @Sakshikumari28 |
@sayande717 What is the progress on this issue? |
@SaptarshiSarkar12 |
Ok, no problem @sayande717 |
If this issue is still open I would like to help. @SaptarshiSarkar12 |
Yes, it is still open. If @sayande717 no longer wants to work, then you (@shivanjaywagh) can be assigned. You (@shivanjaywagh) can also collaborate with @sayande717. |
I don't think I'll be able to actively work on this right now, I have some important college projects coming up so I need to focus on that. So, @SaptarshiSarkar12 , you can assign it to @shivanjaywagh . |
@sayande717 Ok, no problem. @shivanjaywagh You can work on this issue. But, there is some important note : |
@SaptarshiSarkar12 I will join the discord for the further discussion. |
Hi @SaptarshiSarkar12 , I'd like to contribute to this feature as well. I think @keshav08 and I can work together to explore ways to implement it. |
@keshav08 It depends on the speed of development of the feature by the pull request author. I think it should not take more than 2 weeks. |
Sure 👍! @keshav08 That's a good idea as you will get to know when #233 is going to get merged via discord. |
Yes, you both (@keshav08 and @kmr-rohit) can discuss and contribute together on this issue. I am assigning to both of you. |
@SaptarshiSarkar12 So, should I go through the repo for now? And do I have to wait to start coding until the merge? |
Yes, you can go through it. Only the GUI package is going to change, which has no effect on this issue.
@keshav08 @kmr-rohit I have an idea/suggestion on the way this issue can be solved the most reliably. Drifty will check if any update is available by getting the tag_name json field from the JSON response provided by the GitHub API call (https://api.github.com/repos/SaptarshiSarkar12/Drifty/releases/latest?tag_name). The tag_name contains the major, minor and patch version number. Drifty contains a version variable inside the Drifty backend. It will match the fetched version with its current version and if it is outdated, then, it will download and run the updater JavaFX app to which Drifty's current location and type of application (CLI or GUI) will be passed as command line arguments. Hence, Drifty gets updated 🎉!If you have any suggestions on this idea, please let me know. |
You both can start working, no issue! |
@SaptarshiSarkar12 Thank you for your suggestion , me along with @keshav08 will explore the codebase , and try to work in your suggested direction. Will catch you up whenever required. |
Sure 👍! |
@keshav08 @kmr-rohit Is anyone of you interested in working on this issue? If not, I'm going to unassign you. |
As anyone of you (@keshav08 and @kmr-rohit) are no longer interested in working on this issue, so, I'll work on it. |
Is your feature request related to a problem? Please describe.
Currently, Drifty can not detect if the user is running an older version or not. As a result of which, the already fixed errors and new features do not appear in the end user's application.
Describe the solution you'd like.
A feature needs to be introduced such that Drifty can check whether the user is running the latest version of Drifty or not. If the user is running an outdated version, then Drifty should update itself after taking the user's confirmation.
The text was updated successfully, but these errors were encountered: