Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multi-threaded downloading support #162

Merged
merged 7 commits into from
Oct 30, 2022

Conversation

redet-G
Copy link
Contributor

@redet-G redet-G commented Oct 25, 2022

  • Still needs progress bar support

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for drifty ready!

Name Link
🔨 Latest commit ced1358
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/635d7c85c32b0f00089351b0
😎 Deploy Preview https://deploy-preview-162--drifty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SaptarshiSarkar12
Copy link
Owner

Please add progress bar support and then let me know when you are done. @redet-G

@SaptarshiSarkar12
Copy link
Owner

@redet-G You can join my Discord server for the project's discussions .

@redet-G
Copy link
Contributor Author

redet-G commented Oct 25, 2022

@SaptarshiSarkar12 Progress bar support for multithreaded downloading is now complete.

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 Progress bar support for multithreaded downloading is now complete.

Ok @redet-G shall check and inform you when I am done. Thanks .

@SaptarshiSarkar12
Copy link
Owner

@redet-G The program freezes [see image] -
image

@redet-G
Copy link
Contributor Author

redet-G commented Oct 29, 2022

Can you be more specific as to how it could be reproduced? Where the head is right now (commit id)?
The file size is only 14 MB. Multithreading is currently enabled for files above 50 MB. You can modify FileDownloader.threadingThreshold for testing.

image

Here is a screenshot of downloading a file above 50MB.
image
@SaptarshiSarkar12

@SaptarshiSarkar12
Copy link
Owner

Can you be more specific as to how it could be reproduced? Where the head is right now (commit id)? The file size is only 14 MB. Multithreading is currently enabled for files above 50 MB. You can modify FileDownloader.threadingThreshold for testing.

image

Here is a screenshot of downloading a file above 50MB. image @SaptarshiSarkar12

It seems okay from your end. Let me try it again tonight, shall let you know then @redet-G

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀 🚀

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 8386d16 into SaptarshiSarkar12:master Oct 30, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 30, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Added Multithreaded downloading support #145 Added Multi-threaded downloading support Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition App 💻 Issues/Pull Requests which update Drifty Application Code labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
Added Multithreaded downloading support
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
Added Multithreaded downloading support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Multi-threaded downloading for faster download speed
2 participants