Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Drifty Animation in website hero section #171

Merged
merged 11 commits into from
Oct 29, 2022
Merged

Added Drifty Animation in website hero section #171

merged 11 commits into from
Oct 29, 2022

Conversation

IM-TECHNO
Copy link
Contributor

Hello, I made the Drifty text animation in the header sectiion.

This is my last minute Hacktoberfest 2022 PR. Please consider. Thank you.

drifty.mp4

I have attached a video on how it looks. i'll update even more to even better looking site !. Thanks

@IM-TECHNO
Added Drifty Logo Animation
cc054a8 
Drifty logo animation with wave form. thought it be good for the name "Drifty". This is my hacktoberfest submission, please consider
@IM-TECHNO
updated style.css to match changes
e356653 
I updated the style.css to match the changes made to the index.html file.
@netlify
Copy link

netlify bot commented Oct 29, 2022 •
edited

✅ Deploy Preview for drifty ready!

Name Link
🔨 Latest commit 2954c12
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/635d72af635bc50008095d1d
😎 Deploy Preview https://deploy-preview-171--drifty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO The animated text goes out of the screen width in mobiles.
Screenshot_2022-10-29-12-03-25

@SaptarshiSarkar12
Copy link
Owner

Also, please create an issue and link that with this PR. @IM-TECHNO

@IM-TECHNO
Copy link
Contributor Author

I have fixed it now, Will make a PR.

@IM-TECHNO
Update style.css
01095c3 
Optimized for Mobiles
@IM-TECHNO
Copy link
Contributor Author

this commit fixes #172

@IM-TECHNO
Copy link
Contributor Author

drifty-mobile

Fixed. I have verified this on Samsung Galaxy F42 as well as Samsung S21.

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 29, 2022 that may be closed by this pull request
Add Animation to Header Text #172
Closed
@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO Plese make the colour look more prominent in dark mode.
image

@IM-TECHNO
Copy link
Contributor Author

Updated and Fixed the issue. Made the color more prominent.

@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO Please fix this. The animated text goes out of the screen.
Screenshot_2022-10-29-13-50-36

@IM-TECHNO
Copy link
Contributor Author

May I know what's the resolution of the screen that your using right now ?

@SaptarshiSarkar12
Copy link
Owner

May I know what's the resolution of the screen that your using right now ?

Don't know about that but the phone model is Samsung Galaxy J2. @IM-TECHNO

@IM-TECHNO
Copy link
Contributor Author

Okay. Thank you for the INFO, addressing the issue,

@IM-TECHNO
Update style.css
8849451 
fixed resizing issue.
@IM-TECHNO
Copy link
Contributor Author

IM-TECHNO commented Oct 29, 2022 •
edited

I fixed the issue, kindly check on your device.

@SaptarshiSarkar12
Copy link
Owner

SaptarshiSarkar12 commented Oct 29, 2022 •
edited

Sorry, closed this pr by mistake @IM-TECHNO .

@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO You can improve the performance. Refer here - https://www.keycdn.com/blog/animation-performance

@IM-TECHNO
Copy link
Contributor Author

Sure. I'll create another PR. Kindly close this one. (hacktoberfest)

@IM-TECHNO IM-TECHNO mentioned this pull request Oct 29, 2022
Closed
@SaptarshiSarkar12 SaptarshiSarkar12 added invalid This doesn't seem right and removed invalid This doesn't seem right labels Oct 29, 2022
@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO Please fix this. The animated text goes out of the screen. Screenshot_2022-10-29-13-50-36

Not fixed yet @IM-TECHNO . Please fix it as soon as possible.

@IM-TECHNO
Update style.css
2148fe4 
Updated spacing issue.
@IM-TECHNO
Copy link
Contributor Author

IM-TECHNO commented Oct 29, 2022 •
edited

Worked the Whitespacing issue. Please inform if the issue still persists

@SaptarshiSarkar12
Copy link
Owner

Yes it still persists. @IM-TECHNO

@SaptarshiSarkar12
Copy link
Owner

Still persists @IM-TECHNO

@IM-TECHNO
Update style.css
2954c12 
Updated. Tested on a Smaller screen device. Did it help ?, by just a little ?
@SaptarshiSarkar12
Copy link
Owner

Can you improve the performance? @IM-TECHNO It is very low for mobiles and has decreased a bit for desktops.
Check here -
Current - https://pagespeed.web.dev/report?url=https%3A%2F%2Fsaptarshisarkar12.github.io%2FDrifty%2F&form_factor=desktop
with your changes included - https://pagespeed.web.dev/report?url=https%3A%2F%2Fdeploy-preview-171--drifty.netlify.app%2F

SaptarshiSarkar12
SaptarshiSarkar12 approved these changes Oct 29, 2022
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀 🚀.
@IM-TECHNO Please leave a star ⭐ on this project if you liked contributing to it.

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit a47a916 into SaptarshiSarkar12:master Oct 29, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 29, 2022
@IM-TECHNO
Copy link
Contributor Author

Of Course, I loved contributing to Drifty. Starred !

@SaptarshiSarkar12
Copy link
Owner

Of Course, I loved contributing to Drifty. Starred !

Thank you ❤️ @IM-TECHNO!

@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Added Drifty Header Animation Added Drifty Animation in website hero section Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
@SaptarshiSarkar12
Merge pull request #171 from IM-TECHNO/master
7a9c146 
Added Drifty Header Animation
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
@SaptarshiSarkar12
Merge pull request #171 from IM-TECHNO/master
36a59e8 
Added Drifty Header Animation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptarshiSarkar12 SaptarshiSarkar12 SaptarshiSarkar12 approved these changes

Assignees
No one assigned
Labels
feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Animation to Header Text
2 participants
@IM-TECHNO @SaptarshiSarkar12