Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate web-pages created for each nav-bar elements #188

Closed
wants to merge 27 commits into from

Conversation

anantnipunge
Copy link
Contributor

@anantnipunge anantnipunge commented Oct 31, 2022

here i have created separate webpages for each navbar items.

please review this: https://deploy-preview-188--drifty.netlify.app/

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for drifty ready!

Name Link
🔨 Latest commit 3d84743
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/63e4af4bce638f00088f90d1
😎 Deploy Preview https://deploy-preview-188--drifty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anantnipunge
Copy link
Contributor Author

i think still we need to work on each nav elements like adding more features.

@SaptarshiSarkar12
Copy link
Owner

@anantnipunge Please resolve the branch conflicts.

@SaptarshiSarkar12
Copy link
Owner

Also, please make the animation as it is now. @anantnipunge
image

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Nov 1, 2022 that may be closed by this pull request
@anantnipunge
Copy link
Contributor Author

anantnipunge commented Nov 1, 2022

Ok @SaptarshiSarkar12 .

@SaptarshiSarkar12
Copy link
Owner

@anantnipunge Please resolve the branch conflicts and also fix this bug. The color of dark and light mode is same for more info section.
image

@anantnipunge
Copy link
Contributor Author

is there any tool in github or maybe external to see where this conflicts exists in the file? @SaptarshiSarkar12 i'm unable to find conflicts.

@anantnipunge
Copy link
Contributor Author

anantnipunge commented Nov 1, 2022

i have deleted about.css file, but still its showing it's a conflict file.

i think it will take time to resolve conflicts. once done, i will submit it soon.

@SaptarshiSarkar12
Copy link
Owner

is there any tool in github or maybe external to see where this conflicts exists in the file? @SaptarshiSarkar12 i'm unable to find conflicts.

Sorry @anantnipunge I was busy, so I couldn't reply.
You can refer this : https://stackoverflow.com/a/49382772/19187952
This might work.

@SaptarshiSarkar12
Copy link
Owner

i have deleted about.css file, but still its showing it's a conflict file.

i think it will take time to resolve conflicts. once done, i will submit it soon.

at first you delete the conflicting files, pull the latest changes in your local repo and then, make the required changes. This should work.

@anantnipunge
Copy link
Contributor Author

Ok 😊

@anantnipunge
Copy link
Contributor Author

hello @SaptarshiSarkar12 please review the changes

@SaptarshiSarkar12
Copy link
Owner

hello @SaptarshiSarkar12 please review the changes

Please fix this for mobiles.
Screenshot_2022-11-03-15-16-58

@anantnipunge
Copy link
Contributor Author

anantnipunge commented Nov 3, 2022

https://deploy-preview-188--drifty.netlify.app/index.html#contact

It's workin totally fine in my mobile.

@SaptarshiSarkar12
Copy link
Owner

Please see if you can fix this bug @anantnipunge .

@anantnipunge
Copy link
Contributor Author

can you please check it now in your mobile. i made changes and reviewed for 4 to 5 devices on chrome, it's working well and already it was also working well. please review this @SaptarshiSarkar12

@SaptarshiSarkar12
Copy link
Owner

hello @SaptarshiSarkar12 , shadow is removed but i'm unable to provide required feature to the all release section.

i think release section code is written somewhere else, i'm not getting that.

@anantnipunge Yes, the releases section code is written in script.js file starting from line 161. Please check if you can make the All releases section just like Learn More text.

@anantnipunge
Copy link
Contributor Author

Ok i will see.

@SaptarshiSarkar12
Copy link
Owner

Ok i will see.

Have you seen it @anantnipunge ?

@anantnipunge
Copy link
Contributor Author

anantnipunge commented Nov 16, 2022

Sorry for the late. But till friday i'm so busy as there is my exam going on. Till the saturday i will update you for sure.

@SaptarshiSarkar12
Copy link
Owner

Sorry for the late. But till friday i'm so busy as there is my exam going on. Till the saturday i will update you for sure.

Okay 👍.

@anantnipunge
Copy link
Contributor Author

Thanks for understanding!

@SaptarshiSarkar12
Copy link
Owner

Thanks for understanding!

Welcome @anantnipunge 😄

@SaptarshiSarkar12
Copy link
Owner

If you are free, you may resume with the task. @anantnipunge

@anantnipunge
Copy link
Contributor Author

Ok @SaptarshiSarkar12 Apologize for such a long delay. I will look into the website today and will update you.

@SaptarshiSarkar12
Copy link
Owner

Ok @SaptarshiSarkar12 Apologize for such a long delay. I will look into the website today and will update you.

It's okay, take your time. Shall wait for your update, thank you 🙂 .

@anantnipunge
Copy link
Contributor Author

hello @SaptarshiSarkar12 , shadow is removed but i'm unable to provide required feature to the all release section.
i think release section code is written somewhere else, i'm not getting that.

@anantnipunge Yes, the releases section code is written in script.js file starting from line 161. Please check if you can make the All releases section just like Learn More text.

hello @SaptarshiSarkar12 i'm back to project.
i'm facing bit difficulties and errors about this section. but i think i can do it by resolving errors, just need some time till tomorrow night. if it is not possible from me i will update you and i will work on the new feature/ issue.

@SaptarshiSarkar12
Copy link
Owner

hello @SaptarshiSarkar12 , shadow is removed but i'm unable to provide required feature to the all release section.
i think release section code is written somewhere else, i'm not getting that.

@anantnipunge Yes, the releases section code is written in script.js file starting from line 161. Please check if you can make the All releases section just like Learn More text.

hello @SaptarshiSarkar12 i'm back to project. i'm facing bit difficulties and errors about this section. but i think i can do it by resolving errors, just need some time till tomorrow night. if it is not possible from me i will update you and i will work on the new feature/ issue.

Okay, @anantnipunge you can take your time.

@anantnipunge
Copy link
Contributor Author

anantnipunge commented Dec 14, 2022

@SaptarshiSarkar12 i'm facing issue here: can't resolve it. tried all the way but no success.😥
image

@anantnipunge
Copy link
Contributor Author

can you help me or should i work on another issue?

@SaptarshiSarkar12
Copy link
Owner

can you help me or should i work on another issue?

@anantnipunge I am a bit busy now, leave this for now. Work on making the different pages for each nav elements. Make sure that you remove all unnecessary CSS from each of the CSS files.

@anantnipunge
Copy link
Contributor Author

anantnipunge commented Dec 15, 2022

Ok exactly i was thinking abt this 😊. Will ipdate soon.

@SaptarshiSarkar12 if you don't mind. can we have general discussion on discord?

@SaptarshiSarkar12
Copy link
Owner

Ok exactly i was thinking abt this blush. Will ipdate soon.

@SaptarshiSarkar12 if you don't mind. can we have general discussion on discord?

Yeah, sure @anantnipunge .

@anantnipunge
Copy link
Contributor Author

Ok exactly i was thinking abt this blush. Will ipdate soon.

@SaptarshiSarkar12 if you don't mind. can we have general discussion on discord?

Yeah, sure @anantnipunge .

Ok 😇

@SaptarshiSarkar12
Copy link
Owner

@anantnipunge How much work is done? Have you removed unnecessary CSS lines from the files? Have you faced any problem? Feel free to share, shall try to help.

@SaptarshiSarkar12 SaptarshiSarkar12 removed their request for review February 9, 2023 08:32
@SaptarshiSarkar12
Copy link
Owner

Ok exactly i was thinking abt this 😊. Will ipdate soon.

@SaptarshiSarkar12 if you don't mind. can we have general discussion on discord?

@anantnipunge Have you removed unnecessary CSS lines from the files? Has the task been completed? If you have any problem, let me know.

@SaptarshiSarkar12 SaptarshiSarkar12 added the Website 🌐 Issues/Pull Requests regarding Website label Feb 13, 2023
@SaptarshiSarkar12
Copy link
Owner

Closing this due to inactivity. Moreover, the website is going to be revamped via #196 , so this PR is no more required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating separate pages for each nav-element
2 participants