-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for downloading Instagram videos and photos. #223
Added support for downloading Instagram videos and photos. #223
Conversation
…shiSarkar12#216) This commit adds support for downloading videos and photos from Instagram. The new feature uses the yt-dlp program to download the videos and photos in MP4 format. The videos and photos are saved to the current directory or to the directory specified by the dir variable. The commit also adds a new method called downloadFromInstagram() to the FileDownloader class. This method takes a link to an Instagram video or photo and a directory as arguments and downloads the video or photo to the specified directory.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! You did it 🎉 Now, Relax 😉, Grab a drink ☕, and wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀. Thank You 😃!
Meanwhile you can also discuss about the project in our Discord Server 😀
@abhishekkumarXD Please add some screenshots, so that , I can review this as soon as possible. |
I've completed the build and the changes look good. I can provide the build screenshots if you'd like. If you'd like to see the working screenshots of this feature, I'll need some guidance on how to access the CLI application once I've built the Maven project. |
Ok, I need the working screenshots. |
Okay. So, I have built the maven project successfully, now tell me where or how will I find the command line tool (the actual application) so that I can test this new feature @SaptarshiSarkar12 |
@abhishekkumarXD You need to pull the whole git repo (~70 MB), open the project in Intellij Idea and run the Drifty_CLI file under |
… and added support for downloading Instagram Images besides videos Co-Authored-By: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
@abhishekkumarXD Please look into the changes I have added and let me know if you have any suggestions on those, else, we can have this PR merged 👍 🎉 ! |
Instagram Image test link - https://www.instagram.com/p/BZiTZWXABMp/ |
Thank you for the changes you've made @SaptarshiSarkar12. I'm currently reviewing the code and will let you know if I find anything that requires attention. Once I complete the review, we can proceed with merging the pull request. |
Yeah, sure. Thank you @abhishekkumarXD 😄 ! |
I have completed the code review, and everything looks great. Your modifications have been thoroughly reviewed, and I didn't find any issues that require attention. Based on my review, I believe the code is in good shape and ready to be merged. We can now proceed with merging the pull request @SaptarshiSarkar12 🚀 Thank you again for making the necessary changes 😀! |
Yeah, sure. We can proceed with merging this PR. Thank you @abhishekkumarXD for reviewing my changes 😀! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhishekkumarXD Looks good to merge 👍.
Thanks for contributing 🚀 🚀.
You may join our Discord server - https://discord.gg/DeT4jXPfkG to get updates about the project.
Thanks for approving my pull request @SaptarshiSarkar12 😀 I have joined the Discord server and look forward to contributing to this project! ⚡ |
Welcome 😀 @abhishekkumarXD! |
This commit adds support for downloading videos and photos from Instagram. The new feature uses the yt-dlp program to download the videos and photos in MP4 format. The videos and photos are saved to the current directory or to the directory specified by the dir variable.
The commit also adds a new method called downloadFromInstagram() to the FileDownloader class. This method takes a link to an Instagram video or photo and a directory as arguments and downloads the video or photo to the specified directory.
Fixes issue
Fixes #216
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
Instagram Image test link - https://www.instagram.com/p/BZiTZWXABMp/
Instagram Video test link - https://www.instagram.com/p/BDin77DxtAH/ , https://www.instagr.am/p/BDin77DxtAH/