Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to Display Limited Users for "Be a part of Drifty Family! #253

Conversation

PriyansuMaurya
Copy link
Contributor

@PriyansuMaurya PriyansuMaurya commented Aug 24, 2023

Fixes issue

Fixes #252

Changes proposed

  1. Added code to Display Limited no of Users for "Be a part of Drifty Family!" section.
  2. Added Little bit of Responsive improvements in "Be a part of Drifty Family!" section.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

scaling-telegram-4prwp6p6xgjfq79q-3000 app github dev_ (1)

scaling-telegram-4prwp6p6xgjfq79q-3000 app github dev_

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drifty ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 6:26pm

@github-actions github-actions bot added the Website 🌐 Issues/Pull Requests regarding Website label Aug 24, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! You did it 🎉 Now, Relax 😉, Grab a drink ☕, and wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀. Thank You 😃!

Meanwhile you can also discuss about the project in our Discord Server 😀

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya I am requesting some changes on the following :

  • Please add this animation for 43+ circular icon.

    Screencast.from.2023-08-24.20-29-24.webm
  • Revert the animation changes you have made for the contribution, stars and forks buttons for mobile screens. Keep the same animation (violet as background colour when the buttons are hovered) for both desktop and mobile screens.

  • Increase the size of the contribution, stars and forks buttons for mobile screens.
    drifty-e6krvubkg-saptarshisarkar12 vercel app_(Samsung Galaxy S20 Ultra)

  • Change the style of the the contribution, stars and forks buttons to rounded-lg instead of rounded-full.

  • For IPad Mini, the avatars are about to overlap. Please fix that.
    drifty-e6krvubkg-saptarshisarkar12 vercel app_(iPad Mini)

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this changes and let me know when you are done.

Website/app/Contribute.js Outdated Show resolved Hide resolved
Website/app/Contribute.js Outdated Show resolved Hide resolved
Website/app/Contribute.js Outdated Show resolved Hide resolved
Website/app/Contribute.js Outdated Show resolved Hide resolved
@PriyansuMaurya
Copy link
Contributor Author

@SaptarshiSarkar12, I have made the requested changes.

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya Please make the buttons to rounded-lg.
Also, fix the text overflow in mobile screens :
image

@SaptarshiSarkar12
Copy link
Owner

@PriyansuMaurya Also, revert the avatars from square to rounded shape as present in your first commit. The circular shape looks good.

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya Make the view something like this :
image

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya Please make the rounded-lg type of buttons for all displays and not just for mobile screens.
image

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya Please change all the class attributes to className attribute.

PriyansuMaurya and others added 2 commits August 25, 2023 11:21
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya Along with the below changes, please change the lg:mt-20 attribute in line number 9 to lg:mt-16.

Website/app/Contribute.js Outdated Show resolved Hide resolved
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya Please keep the partially rounded buttons by removing the md:rounded-full attribute.

Website/app/Contribute.js Outdated Show resolved Hide resolved
Website/app/Contribute.js Outdated Show resolved Hide resolved
Website/app/Contribute.js Outdated Show resolved Hide resolved
PriyansuMaurya and others added 3 commits August 25, 2023 11:36
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya In IPad Mini, the GitHub avatars are about to overlap. Can you please add some space/gap between two consecutive avatars (might be gap-1) ?
image

@PriyansuMaurya
Copy link
Contributor Author

PriyansuMaurya commented Aug 25, 2023

After a gap-2, it was still not resolved. Therefore, I had to make changes to achieve what you wanted:

width={80} height={80} => width={64} height={64}

If you believe that further changes are necessary, please note that I am not available for them. You can proceed to close this pull request.

@SaptarshiSarkar12
Copy link
Owner

After a gap-2, it was still not resolved. Therefore, I had to make changes to achieve what you wanted:

width={80} height={80} => width={64} height={64}

If you believe that further changes are necessary, please note that I am not available for them. You can proceed to close this pull request.

@PriyansuMaurya It is fine if you have changed the image size. Also, no more changes are required for the IPad Mini case. But, there is some small syntactical and some logical changes required.

Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyansuMaurya Looks good to merge 👍.
Thanks for contributing 🚀 🚀.
You may join our Discord server - https://discord.gg/DeT4jXPfkG to get updates about the project.

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit e9b0dad into SaptarshiSarkar12:master Aug 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decluttering Home Page: Avoid Displaying All Users
2 participants