-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added code to Display Limited Users for "Be a part of Drifty Family! #253
Added code to Display Limited Users for "Be a part of Drifty Family! #253
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! You did it 🎉 Now, Relax 😉, Grab a drink ☕, and wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀. Thank You 😃!
Meanwhile you can also discuss about the project in our Discord Server 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya I am requesting some changes on the following :
-
Please add this animation for 43+ circular icon.
Screencast.from.2023-08-24.20-29-24.webm
-
Revert the animation changes you have made for the contribution, stars and forks buttons for mobile screens. Keep the same animation (violet as background colour when the buttons are hovered) for both desktop and mobile screens.
-
Increase the size of the contribution, stars and forks buttons for mobile screens.
-
Change the style of the the contribution, stars and forks buttons to
rounded-lg
instead ofrounded-full
. -
For IPad Mini, the avatars are about to overlap. Please fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this changes and let me know when you are done.
@SaptarshiSarkar12, I have made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya Please make the buttons to rounded-lg
.
Also, fix the text overflow in mobile screens :
@PriyansuMaurya Also, revert the avatars from square to rounded shape as present in your first commit. The circular shape looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya Make the view something like this :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya Please make the rounded-lg
type of buttons for all displays and not just for mobile screens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya Please change all the class
attributes to className
attribute.
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya Along with the below changes, please change the lg:mt-20
attribute in line number 9 to lg:mt-16
.
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya Please keep the partially rounded buttons by removing the md:rounded-full
attribute.
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya In IPad Mini, the GitHub avatars are about to overlap. Can you please add some space/gap between two consecutive avatars (might be gap-1
) ?
After a
If you believe that further changes are necessary, please note that I am not available for them. You can proceed to close this pull request. |
@PriyansuMaurya It is fine if you have changed the image size. Also, no more changes are required for the IPad Mini case. But, there is some small syntactical and some logical changes required. |
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PriyansuMaurya Looks good to merge 👍.
Thanks for contributing 🚀 🚀.
You may join our Discord server - https://discord.gg/DeT4jXPfkG to get updates about the project.
Fixes issue
Fixes #252
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers