Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Download History in CLI #306

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

Abhishek2nayak
Copy link
Contributor

@Abhishek2nayak Abhishek2nayak commented Oct 9, 2023

Fixes issue

Fixes #283

Changes proposed

  1. Added Download History Support in CLI
  2. Improve user engagement by prompting users to decide whether to download the same file again.
  3. Added code that generate unique filename so there is no collision between previous files.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

2023-10-09-16-41-57_aPCSH16f.mp4

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drifty ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 7:09am

@github-actions github-actions bot added App 💻 Issues/Pull Requests which update Drifty Application Code dependencies 📦️ Pull Requests that update dependencies maven 📦️ Pull Requests that update Maven dependencies labels Oct 9, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! You did it 🎉 Now, Relax 😉, Grab a drink ☕, and wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀. Thank You 😃!

Meanwhile you can also discuss about the project in our Discord Server 😀

@Abhishek2nayak
Copy link
Contributor Author

Abhishek2nayak commented Oct 9, 2023

@SaptarshiSarkar12 what is this error means?
##Build and Package Drifty / build-Drifty (macos-latest) (pull_request)

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 what is this error means? ##Build and Package Drifty / build-Drifty (macos-latest) (pull_request)

@Abhishek2nayak The name is not an error name. It is GitHub Actions run name. The error was something related to GraalVM's Platform.DARWIN_AMD64 class causing build failure. But now, it has got resolved. It might be a transient error as it has previously been fixed.

…video restriction for YouTube videos to prevent breaking of duplicate filename detection process
@github-actions github-actions bot removed dependencies 📦️ Pull Requests that update dependencies maven 📦️ Pull Requests that update Maven dependencies labels Oct 11, 2023
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishek2nayak Looks good to merge 👍.
Thanks for contributing 🚀 🚀.
You may join our Discord server - https://discord.gg/DeT4jXPfkG to get updates about the project.

@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Added Download History Support in CLI feat: Added Support for Download History in CLI Oct 11, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 merged commit deff9f4 into SaptarshiSarkar12:master Oct 11, 2023
10 checks passed
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 11, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title feat: Added Support for Download History in CLI Added Support for Download History in CLI Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Support for Download History in Drifty CLI
2 participants