Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the resizing functionality of the textarea in the contact form #337

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Hristo-Spasov
Copy link
Contributor

Fixes issue

Fixes #336

Changes proposed

Disabling the resizing functionality.
Also removed few unused CSS styles.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

fix

Note to reviewers

Also removed few lines of unused CSS styles.

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drifty ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 4:47pm

@github-actions github-actions bot added the Website 🌐 Issues/Pull Requests regarding Website label Nov 14, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! You did it 🎉 Now, Relax 😉, Grab a drink ☕, and wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀. Thank You 😃!

Meanwhile you can also discuss about the project in our Discord Server 😀

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trickkyyy Please fix this bug for mobile screens. The navbar is not appearing completely - might be because of overflow hidden attribute.

screen-20231115-095501.mp4

@SaptarshiSarkar12 SaptarshiSarkar12 added the bug 🐛 Issues/Pull Requests reporting/fixing a bug label Nov 15, 2023
@Hristo-Spasov
Copy link
Contributor Author

Hristo-Spasov commented Nov 15, 2023

@SaptarshiSarkar12 There requested change has been made also I saw another minor bug in the header while on mobile.
When scrolling the Navigation bar change color without the need of such behavior.

Screenshots of the requested change:

bug_fix1

bug_fix11

Video of the other bug fix:

Before:

bug.mp4

After:

bug_fix.mp4

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trickkyyy Looks good to merge 👍.
Thanks for contributing 🚀 🚀.
Please leave a star ⭐ to this project if you liked contributing to it
You may join our Discord server - https://discord.gg/DeT4jXPfkG to get updates about the project.

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 42798c1 into SaptarshiSarkar12:master Nov 16, 2023
5 checks passed
@Hristo-Spasov Hristo-Spasov deleted the issue336 branch November 16, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues/Pull Requests reporting/fixing a bug Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Overflow at the bottom of the Contact Page
2 participants