Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple changes made to the website #57

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Multiple changes made to the website #57

merged 1 commit into from
Oct 6, 2022

Conversation

Waxer59
Copy link
Contributor

@Waxer59 Waxer59 commented Oct 5, 2022

#60

What have I added?

  • I have organized the css
  • I have added semantic html to the footer
  • I fixed the dark mode toggle ( Currently if you activate the bright mode and reload the page the darkmode toggle is inverted and causes you to have errors when changing themes. )
  • I have deleted unused css

Why do I think this will improve the project?

These changes make it easier to locate the css when another contributor wants to support the project.

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀 🚀

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit bd1f648 into SaptarshiSarkar12:master Oct 6, 2022
@SaptarshiSarkar12
Copy link
Owner

@Waxer59 Although I have approved and merged it, you need to create an issue and link that to this.

@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 6, 2022
@SaptarshiSarkar12
Copy link
Owner

@Waxer59 Although I have approved and merged it, you need to create an issue and link that to this.

@Waxer59 Please make an issue. It is important for maintaining the progress of this project.

@Waxer59
Copy link
Contributor Author

Waxer59 commented Oct 6, 2022

Okay, I'm doing it

@Waxer59
Copy link
Contributor Author

Waxer59 commented Oct 6, 2022

Done

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 6, 2022 that may be closed by this pull request
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Multiple changes Multiple changes made to the website Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
Multiple changes have been made on the website.
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
Multiple changes have been made on the website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to organize and fix parts of the website
2 participants