Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

SARAALERT-1599: Update Vaccine Products Names to CDC Formatting #1064

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

ngfreiter
Copy link
Contributor

@ngfreiter ngfreiter commented Sep 1, 2021

Description

Jira Ticket: SARAALERT-1599

This updates product_name for vaccines to be in compliance with the official CDC product names for the relevant vaccines. We are doing this to minimize any variation in the names of the vaccines.

Important Changes

vaccines.yaml

  • Update vaccine names to match CDC guidance

advancedFilterOptions.js

  • Update vaccine names to match CDC guidance

db/migrate

  • Add a migration for going from the old "new" vaccine product names to the new new vaccine names

public/Sara Alert Import Format.xlsx

  • Update guidance, example, and section detailing updates

test/*

  • Update all test files to match new vaccine names

Testing Recommendations

  • The new values are used in the UI
  • The new values are used in import
  • The new values are used in the API
  • If you migrate from a database using the old values, the values are correctly updated on:
    • Vaccine records
    • UserExportPreset records which use the vaccines in their config
    • UserFilter records which filter based on these product names
  • If you migrate back, the reverse happens

Checklists

Submitter:

  • This PR describes why these changes were made.
  • This PR is into the correct branch.
  • This PR includes the correct JIRA ticket reference.
  • Comment added to the relevant JIRA ticket(s) with a link to this PR
  • Code diff has been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, Chrome Dev Tools Lighthouse accessibility test has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary

@Bialogs

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code
  • If applicable, you have tested changes against a large database, and considered possible performance regressions
  • Tested all recommendations listed in the "Testing Recommendations" section. The application behaves as expected with this PR.

@tstrass

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code
  • If applicable, you have tested changes against a large database, and considered possible performance regressions
  • Tested all recommendations listed in the "Testing Recommendations" section. The application behaves as expected with this PR.

@sgober

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code
  • If applicable, you have tested changes against a large database, and considered possible performance regressions
  • Tested all recommendations listed in the "Testing Recommendations" section. The application behaves as expected with this PR.

We are updating vaccine names again to match the names listed here:
https://www2a.cdc.gov/vaccines/iis/iisstandards/vaccines.asp?rpt=tradename

for sake of consistency over time.
We had previously updated the names of the vaccines and added
new vaccines in a prior migration, but this migration is needed
to update all of the existing vaccines to match the product name
values used by the cdc.
@tstrass tstrass added this to the 1.36.1 milestone Sep 1, 2021
tstrass
tstrass previously approved these changes Sep 1, 2021
sgober
sgober previously approved these changes Sep 1, 2021
@tstrass tstrass dismissed stale reviews from sgober and themself via 11b2af4 September 1, 2021 22:29
@tstrass tstrass requested a review from Bialogs September 1, 2021 23:23
@tstrass tstrass merged commit fc3603c into master Sep 2, 2021
@tstrass tstrass deleted the 1599-update-vaccine-product-names-to-cdc branch September 2, 2021 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants