Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for irony-server in irony.el directory #537

Closed

Conversation

matthewbauer
Copy link

This makes irony--find-server-executable look in
/server/bin for the irony-server executable. This is
useful when you want the irony-server executable to be preinstalled
system-wide in your Emacs setup. This saves users the trouble of
having to individually build irony-server and have all of the
dependencies that come with it.

This makes irony--find-server-executable look in
<load-file-name>/server/bin for the irony-server executable. This is
useful when you want the irony-server executable to be preinstalled
system-wide in your Emacs setup. This saves users the trouble of
having to individually build irony-server and have all of the
dependencies that come with it.
@Sarcasm
Copy link
Owner

Sarcasm commented Jun 10, 2019

Do you have a package manager in mind that does this, or some other Emacs module?

For a system package manager, I would expect irony-server to end up in the user PATH eventually, which I think already works.
I'm not sure how and where Elpa packages are supposed to install binaries or Emacs modules, but I don't really want to invent multiple conventions of my own.

@matthewbauer
Copy link
Author

Yeah, just putting it in PATH makes sense. ELPA doesn't really have a way to handle executables though, so it's a little bit weird. In Nixpkgs, we just put everything into /share/emacs/site-lisp/elpa/<pkg>. But I think it can be changed to put it in /bin instead.

matthewbauer added a commit to matthewbauer/nixpkgs that referenced this pull request Jun 11, 2019
This has melpaBuild compile the irony-server executable automatically.
This means each user of the irony executable doesn’t have to wait for
it to compile on each new use. This depends on this PR to work
correctly:

Sarcasm/irony-mode#537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants