Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Momentum Calculator #535

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Momentum Calculator #535

merged 2 commits into from
Oct 29, 2023

Conversation

Pasqua101
Copy link
Contributor

Issue Id you have worked upon -

Issue #531

Briefly explain your program logic -

As mentioned in issue #531. I have created a momentum calculator that takes in mass (kg) and velocity (m/s) and returns a value of kg m/s for the momentum. There is also has a info file explaining the purpose of the calculator.

Additionally, I have added this calculator to the list of currently implemented physics calculators and removed the duplicate physics header from the README.

Screenshots(Attach 2 screenshots of your own input and output) -

image
image


By raising this PR I affirm that -

  • My code follows the guidelines of this project.

  • I have performed a self-review of my own code.

  • I have commented my code.

  • My code gives the correct output.

  • I affirm that I strictly follow contributing guidelines and code of conduct.

…moved a duplicate Physics header, and corrected a spelling mistake for one of the chemistry calculators.
@SarthakKeshari
Copy link
Owner

@Pasqua101,
In the readme file while adding your changes, you have removed the Physics section. Kindly revert the Readme file.

@Pasqua101
Copy link
Contributor Author

Hi @SarthakKeshari , I only removed a duplication of the Physics section. Please look at the attached screenshot below that shows the deletion of the duplicate Physics section that opts for the one that has more of the calculators.
image

Additionally, you can see this duplication on the current version of the README on the main page. As seen below.
image

The changes to made to the README address this duplication. However, if this is not what you want, I can revert this. Please let me know. Thank you.

@SarthakKeshari
Copy link
Owner

@Pasqua101,
Thanks for the help. I got your point. 😊

@SarthakKeshari SarthakKeshari self-assigned this Oct 29, 2023
@SarthakKeshari SarthakKeshari added easy Easy Level Calculator - 5 points hacktoberfest2023 Under Hacktoberfest 2023 hacktoberfest-accepted labels Oct 29, 2023
@SarthakKeshari SarthakKeshari linked an issue Oct 29, 2023 that may be closed by this pull request
12 tasks
@SarthakKeshari SarthakKeshari merged commit 18f8fab into SarthakKeshari:master Oct 29, 2023
1 check passed
@SarthakKeshari
Copy link
Owner

@Pasqua101,
Glad to see you have updated the Info file. Appreciating your efforts by adding admin-appreciation points. 👏👏

@SarthakKeshari
Copy link
Owner

Congratulations 🎉 @Pasqua101 on your contribution.
Thanks for adding value to this repository. 😊

Let's celebrate this fest 😃 by providing more developers 👨‍💻👩‍💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.

Your efforts can make difference.

@SarthakKeshari
Copy link
Owner

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐

image

@SarthakKeshari SarthakKeshari added the admin-appreciation 🎁 5 points for impressive contribution label Oct 29, 2023
@Pasqua101
Copy link
Contributor Author

Done. Thanks for accepting my PR!

@SarthakKeshari SarthakKeshari added the 🎉ranked Ranklist updated for this merge label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin-appreciation 🎁 5 points for impressive contribution easy Easy Level Calculator - 5 points hacktoberfest2023 Under Hacktoberfest 2023 hacktoberfest-accepted 🎉ranked Ranklist updated for this merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Momentum Calculator
2 participants